Skip to content

ci: [2.X] CI failures fixes #3302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Feb 24, 2025
Merged

ci: [2.X] CI failures fixes #3302

merged 19 commits into from
Feb 24, 2025

Conversation

@michalChrobot
Copy link
Collaborator

@michalChrobot michalChrobot commented Feb 18, 2025 •
edited
Loading

This PR addresses some test failures in new CI definition (present on develop-2.0.0 branch)

  1. Code Coverage test failure --> This test was failing because packed package couldn't be find. This steams from the fact that the path was wrongly pointing to different place because package pack job was modified to fix this.
  2. minimalproject standards failure --> We were focusing before on making sure that testproject is conforming to standards (which also means that NGO package conforms to standards) but minimalproject has few errors which we aim to fix in this PR
  3. testproject-tools-integration standards failure --> We were focusing before on making sure that testproject is conforming to standards (which also means that NGO package conforms to standards) but testproject-tools-integration has few errors which we aim to fix in this PR

@michalChrobot michalChrobot self-assigned this Feb 18, 2025
@michalChrobot michalChrobot mentioned this pull request Feb 18, 2025
Closed
michalChrobot and others added 3 commits February 18, 2025 11:35
@michalChrobot
Linter correction
a087bbe
@NoelStephensUnity
fix
801297c 
Fixing standards checks issues.
Fixing issue with using the upm candidates.
@NoelStephensUnity
fix
4598705 
Adding Rider editor support for standards checks.
NoelStephensUnity and others added 14 commits February 19, 2025 08:56
@michalChrobot michalChrobot marked this pull request as ready for review February 24, 2025 09:29
@NoelStephensUnity NoelStephensUnity merged commit 84c06c7 into develop-2.0.0 Feb 24, 2025
27 checks passed
@NoelStephensUnity NoelStephensUnity deleted the ci-test-fixes-develop-2.0.0 branch February 24, 2025 20:51
@michalChrobot michalChrobot added port:1.x-needed This issue needs to be ported to 1.X branch port:1.x-completed This issue was ported to 1.X branch labels Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NoelStephensUnity NoelStephensUnity NoelStephensUnity approved these changes

@miniwolf miniwolf Awaiting requested review from miniwolf

@fluong6 fluong6 Awaiting requested review from fluong6

@EmandM EmandM Awaiting requested review from EmandM EmandM is a code owner

Assignees

@michalChrobot michalChrobot

Labels

port:1.x-completed This issue was ported to 1.X branch port:1.x-needed This issue needs to be ported to 1.X branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@michalChrobot @NoelStephensUnity