ci: [2.X] Turn off title validation for single commit PRs #3314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmandM
requested review from
NoelStephensUnity,
fluong6,
michalChrobot and
miniwolf
as code owners
michalChrobot
approved these changes
Feb 21, 2025
Collaborator
michalChrobot
left a comment
michalChrobot
left a comment
There was a problem hiding this comment.
Nice! Thanks, I was starting to get confused by this check failing when PR had only 1 commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.x
When the semantic commit action was added into the branch, the default squash commit for a pr with only a single commit was the commit name and not the PR title. Since then, Github has added a feature to allow configuration of the default and we have that setting set in our repo.
This PR turns off the validation of commits as the check is not valid anymore.