ci: [NGOv2.X] Fixing WhenAnticipating_ValueChangesImmediately test #3331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalChrobot
changed the title
michalChrobot
requested review from
a team,
EmandM,
NoelStephensUnity,
fluong6 and
miniwolf
as code owners
NoelStephensUnity
approved these changes
Mar 13, 2025
Collaborator
NoelStephensUnity
left a comment
NoelStephensUnity
left a comment
There was a problem hiding this comment.
looks good to me. 👍
NoelStephensUnity
pushed a commit
that referenced
this pull request
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focuses on addressing disabled WhenAnticipating_ValueChangesImmediately on Android devices which is located in
com.unity.netcode.gameobjects/Tests/Runtime/NetworkTransformAnticipationTests.csand tracked via MTT-11341The error that is happening says
name: Unity.Netcode.RuntimeTests.NetworkTransformAnticipationTests.WhenAnticipating_ValueChangesImmediately result: FAILED message: Expected: (-0.28337, 0.21980, 0.06689, 0.93108) But was: (-0.28337, 0.21980, 0.06689, 0.93108) stackTrace: at Unity.Netcode.RuntimeTests.NetworkTransformAnticipationTests.WhenAnticipating_ValueChangesImmediately () [0x00000] in <00000000000000000000000000000000>:0 duration: 0.023017 secondsWhich seems to be an FP comparison problem (since the values seem to be correct). The approach is to use quaternion comparer with default error value of 0.000001 to mitigate this issue (DOCS)