fix: android time test failures due to edge case float precision errors #3351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding additional debug information.
Cleaning up TimeInitializationTest a bit.
Removing extra CR.
michalChrobot
approved these changes
Mar 18, 2025
Collaborator
michalChrobot
left a comment
michalChrobot
left a comment
There was a problem hiding this comment.
Nice, thanks for fixing this so fast!
michalChrobot
pushed a commit
that referenced
this pull request
Mar 19, 2025
…rs (#3351) `NetworkTimeSystemTests.CorrectAmountTicksTest` Using the double version of tick frequency to calculate number of ticks passed. `TimeInitializationTest.TestClientTimeInitializationOnConnect` Dividing the double version of tick frequency to calculate number of ticks passed and using the double version of `Math.Floor` before casting that to an integer. ## Changelog NA ## Testing and Documentation - Includes integration test updates. - No documentation changes or additions were necessary. <!-- Uncomment and mark items off with a * if this PR deprecates any API: ### Deprecated API - [ ] An `[Obsolete]` attribute was added along with a `(RemovedAfter yyyy-mm-dd)` entry. - [ ] An [api updater] was added. - [ ] Deprecation of the API is explained in the CHANGELOG. - [ ] The users can understand why this API was removed and what they should use instead. -->
michalChrobot
added a commit
that referenced
this pull request
Apr 2, 2025
…cision errors (#3352) This PR is a backport of #3351 Some changes were not included because those were already present on develop branch. All Android tests passed before merging Co-authored-by: Noel Stephens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NetworkTimeSystemTests.CorrectAmountTicksTestUsing the double version of tick frequency to calculate number of ticks passed.
TimeInitializationTest.TestClientTimeInitializationOnConnectDividing the double version of tick frequency to calculate number of ticks passed and using the double version of
Math.Floorbefore casting that to an integer.Changelog
NA
Testing and Documentation