fix: NetworkAnimator logging error when a state has no destination information #3384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmandM
approved these changes
Apr 7, 2025
| NetworkLog.LogError($"[DestinationState To Transition Info] Layer ({animationState.Layer}) does not exist!"); | ||
| } | ||
| // For reference, it is valid to have no transition information | ||
| //else if (NetworkManager.LogLevel == LogLevel.Developer) |
There was a problem hiding this comment.
I think it's maybe best to remove the commented out code and simply leave the comment?
There was a problem hiding this comment.
Yeah... I was thinking that too but wanted to keep it here until we do a full overhaul of NetworkAnimator.
NoelStephensUnity
deleted the
fix/do-not-log-error-when-no-animator-transition-information
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR remove the error log when a state has no transition information associated with it.
MTTB-1153
Changelog
NetworkAnimatorwould log an error if there was no destination transition information.Testing and Documentation