fix: Extended UniversalRpcTests run times #3560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored some of the UniversalRpcTests which brings the total test count down from 10K+ to around 3.5k tests.
Handling some PVP issues.
michalChrobot
approved these changes
Jul 24, 2025
|
I will first run the wrench tests locally on this branch to see if it fixes the problem |
Updating the revised test to have a longer timeout and to log messages to avoid a "no log" timeout.
Fixing a timeout that could occur within UnityTransport. Refactoring the optimizations on the two group override tests in order to provide a heartbeat to the logger while running through that set of tests.
Forgot to remove the two tests from the general tests enums list.
Fixing stability issue where message corruption could potentially fail if none of the 1st 4 bytes were 0. Refactoring TestSendingWithSingleNotOverride and TestSendingWithSingleOverride to use a ValuesAttribute decorated SendTo parameter to assure it provides a heartbeat to the logger.
NoelStephensUnity
added a commit
that referenced
this pull request
Jul 30, 2025
Up-porting some of the fixes and optimizations applied to v1.14.0 branch. The total test count prior to optimizations: <img width="641" height="642" alt="image" src="https://github.com/user-attachments/assets/d45a0b22-a9ae-4674-b176-ec25646503ae" /> The total test count after optimizations: <img width="638" height="635" alt="image" src="https://github.com/user-attachments/assets/632897f6-9381-42b3-b5d0-b83e9e06cda9" /> ## Changelog NA ## Testing and Documentation - Includes integration test fixes and refactoring. - No documentation changes or additions were necessary. <!-- Uncomment and mark items off with a * if this PR deprecates any API: ### Deprecated API - [ ] An `[Obsolete]` attribute was added along with a `(RemovedAfter yyyy-mm-dd)` entry. - [ ] An [api updater] was added. - [ ] Deprecation of the API is explained in the CHANGELOG. - [ ] The users can understand why this API was removed and what they should use instead. --> ## Backport This is the up-port of #3560. <!-- If this is a backport: - Add the following to the PR title: "\[Backport\] ..." . - Link to the original PR. If this needs a backport - state this here If a backport is not needed please provide the reason why. If the "Backports" section is not present it will lead to a CI test failure. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR condenses the total number of tests from roughly ~10k down to ~3.5k by grouping like test types and migrating all
[Values]decorated parameters to local properties.This helps to reduce:
Changelog
NA
Testing and Documentation
UniversalRpcTestsrefactoring.UniversalRpcGroupedTests.UniversalRpcGroupedTests.Backport
This most likely could be up-ported to v2.x, but for the time being this should be reviewed merged for the v1.14.0 release.