Skip to content

fix: connection approval cannot exceed mtu size - backport (3564) #3565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 30, 2025
Merged

fix: connection approval cannot exceed mtu size - backport (3564) #3565

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bf0b78b
fix
NoelStephensUnity Jul 28, 2025
f1aeb58
test
NoelStephensUnity Jul 28, 2025
724f609
update
NoelStephensUnity Jul 28, 2025
14d409d
Merge branch 'develop' into fix/connection-approval-cannot-exceed-MTU…
NoelStephensUnity Jul 29, 2025
1089d5a
Merge branch 'develop' into fix/connection-approval-cannot-exceed-MTU…
EmandM Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions com.unity.netcode.gameobjects/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,16 @@ Additional documentation and release notes are available at [Multiplayer Documen

### Added

### Fixed

- Fixed issue where NetworkConfig.ConnectionData could cause the ConnectionRequestMessage to exceed the transport's MTU size and would result in a buffer overflow error. (#3565)

### Changed

## [1.14.0] - 2025-07-21

### Added

- Added serializer for `Pose` (#3540)
- Added mappings between `ClientId` and `TransportId`. (#3515)
- Added `SinglePlayerTransport` that provides the ability to start as a host for a single player network session. (#3475)
Expand Down
2 changes: 1 addition & 1 deletion com.unity.netcode.gameobjects/Runtime/Connection/NetworkConnectionManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,7 +626,7 @@ private void SendConnectionRequest()
}
}

SendMessage(ref message, NetworkDelivery.ReliableSequenced, NetworkManager.ServerClientId);
SendMessage(ref message, NetworkDelivery.ReliableFragmentedSequenced, NetworkManager.ServerClientId);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮 That'd do it

message.MessageVersions.Dispose();
}

Expand Down
11 changes: 8 additions & 3 deletions com.unity.netcode.gameobjects/Tests/Runtime/ConnectionApproval.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public ConnectionApprovalTests(PlayerCreation playerCreation)

protected override int NumberOfClients => 1;

private Guid m_ValidationToken;
private string m_ValidationToken;

protected override bool ShouldCheckForSpawnedPlayers()
{
Expand All @@ -46,8 +46,13 @@ protected override void OnServerAndClientsCreated()
m_ClientDisconnectReasonValidated = false;
m_BypassConnectionTimeout = m_PlayerCreation == PlayerCreation.FailValidation;
m_Validated.Clear();
m_ValidationToken = Guid.NewGuid();
var validationToken = Encoding.UTF8.GetBytes(m_ValidationToken.ToString());
m_ValidationToken = string.Empty;

while (m_ValidationToken.Length < 2000)
{
m_ValidationToken += Guid.NewGuid().ToString();
}
var validationToken = Encoding.UTF8.GetBytes(m_ValidationToken);
m_ServerNetworkManager.ConnectionApprovalCallback = NetworkManagerObject_ConnectionApprovalCallback;
m_ServerNetworkManager.NetworkConfig.PlayerPrefab = m_PlayerCreation == PlayerCreation.Prefab ? m_PlayerPrefab : null;
if (m_PlayerCreation == PlayerCreation.PrefabHash)
Expand Down