Release/1.14.0 merge back in develop #3569
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- Replace this block with what this PR does and why. Describe what you'd like reviewers to know, how you applied the engineering principles, and any interesting tradeoffs made. Delete bullet points below that don't apply, and update the changelog section as appropriate. --> I don't have github access to modify release branches directly, so creating this PR here. <!-- Add short version of the JIRA ticket to the PR title (e.g. "feat: new shiny feature [MTT-123]") --> ## Backport <!-- If this is a backport: - Add the following to the PR title: "\[Backport\] ..." . - Link to the original PR. If this needs a backport - state this here If a backport is not needed please provide the reason why. If the "Backports" section is not present it will lead to a CI test failure. -->
This PR condenses the total number of tests from roughly ~10k down to ~3.5k by grouping like test types and migrating all `[Values]` decorated parameters to local properties. **This helps to reduce:** - The time spent setting up and tearing down a test for each unique parameter value combination. - The time spent starting and stopping NetworkManagers. - The total number of tests is more than cut in half. - _There is a known limitation with 2021 & 2022 TestRunner where reaching/exceed the 8-10k total tests count range can start to impact performance._ ## Changelog NA ## Testing and Documentation - Includes some `UniversalRpcTests` refactoring. - Includes new `UniversalRpcGroupedTests`. - Includes commenting out all legacy tests that were migrated into `UniversalRpcGroupedTests`. <!-- Uncomment and mark items off with a * if this PR deprecates any API: ### Deprecated API - [ ] An `[Obsolete]` attribute was added along with a `(RemovedAfter yyyy-mm-dd)` entry. - [ ] An [api updater] was added. - [ ] Deprecation of the API is explained in the CHANGELOG. - [ ] The users can understand why this API was removed and what they should use instead. --> ## Backport This most likely could be up-ported to v2.x, but for the time being this should be reviewed merged for the v1.14.0 release. <!-- If this is a backport: - Add the following to the PR title: "\[Backport\] ..." . - Link to the original PR. If this needs a backport - state this here If a backport is not needed please provide the reason why. If the "Backports" section is not present it will lead to a CI test failure. -->
Going to see if this resolves the issue with 2021.3 windows validation and the memory disposed error message.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge back changes from 1.14.0 release