-
Notifications
You must be signed in to change notification settings - Fork 457
chore: PR template and validation updates #3577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ore mandatory sections
Note that currently backport-verification and Pull Request Trigger are still required as those are taken from repo settings and I need to modify those (which will affect all other PRs) to make 100% sure that my changes work as expected. When we will agree to merge this PR then I will
So just notice that it may take me up to 20m of possible disruption. After that ALL PRs will need to pull latest changes so they work correctly |
Purpose of this PR
This PR aims to address some areas for the ease of Playtesting and validation of our changes. Important to note are the following changes:
Updated PR template with more sections where (REQUIRED for a PR to be merged) Documentation, Testing and QA, and Backport sections. I renamed the git workflow and I will update the name in the settings when merging this PR so for now you can see backport-verification pending since it doesn't exist anymore.
Newly introduced sections are
Such updated PR template will look as follows

Another thing to note is that Documentation section was added to the changelog to group any changes of this kind (since it would be unintuitive to count them as fixed or added)
One more thing that I'm updating is that I failed to notice that targets and drafts conditions are configured as separate items in a list. In our CI, basic triggers in a list are combined with an OR operator, meaning the job will run if any of the conditions are met. This lead to test being executed on draft PRs. What I'm changing is
Note that the test will execute now on whatever branch if we will specifically want that (by typing /ci ngo)
Jira ticket
MTT-12822
Documentation
No documentation changes or additions were necessary.
Testing & QA
This change won't affect users and focuses around our workflow and templates so no testing is needed
Backport
Will be backported when we agree to the shape of it