fix: Correct error message about send queue being full #3593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalChrobot
approved these changes
Aug 13, 2025
Collaborator
michalChrobot
left a comment
michalChrobot
left a comment
There was a problem hiding this comment.
Nice catch, LGTM, I also agree that we don't need a changelog entry for this correction
Collaborator
|
FYI the CMB Service Test failure is a know issue that Noel is addressing *update, it was fixed and I merged latest content from |
NoelStephensUnity
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Error message you get when the UTP send queue is full would indicate to increase the 'Max Send Queue Size' parameter. But it really should be the 'Max Packet Queue Size'. The send queue size is not something users should have to modify since we increase dynamically as needed. The packet queue size however should be increased by users if needed since we can't increase it dynamically (at least with current UTP).
Changelog
Didn't seem worthy of a changelog entry. Can add one if requested.
Testing & QA
No need to test anything. It's just a string change.
Documentation
No documentation changes necessary.
Backport
#3594