Skip to content

chore: install protocol buffer before building service #3599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Aug 14, 2025
Merged

chore: install protocol buffer before building service #3599

merged 15 commits into from
Aug 14, 2025

Conversation

@NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Aug 13, 2025

Purpose of this PR

The most recent service update added a dependency to the protocol buffer compiler. This PR adds the protocol buffer driver to the CI DA service build script.

Jira ticket

NA

Documentation

  • No documentation changes or additions were necessary.

Testing & QA

Functional Testing

Manual testing :

  • Manual testing done
    • Via back-end CI.

Automated tests:

  • Covered by existing automated tests
  • Covered by new automated tests

Does the change require QA team to:

  • Review automated tests?
  • Execute manual tests?

If any boxes above are checked, please add QA as a PR reviewer.

Backport

No back port is required (a v2.x.x only update)

@NoelStephensUnity
update
eb28f77 
Installing the protobuffer compiler before building the Rust server.
@NoelStephensUnity
update
27bdb21 
Using apt-get as opposed to apt.
@NoelStephensUnity
update
d9bfc3c 
Adding the environment variable to what I "think" is the correct location of the install.
@NoelStephensUnity
update
63569bc 
Adding PROTOC environment variable.
@NoelStephensUnity
update
58c92a9 
Seeing if I can download the binary to a known location and then set environment variables to point to that.
Adding some additional log information.
@NoelStephensUnity
update - chmod
8cb1f26 
Updating the subfolders to have execute permissions.
@NoelStephensUnity
update - style
b3bb9da 
Adjusting comments and
@NoelStephensUnity
update
4a31084 
recursively change read/write an execution permissions.
@NoelStephensUnity
update
bf7f665 
Trying the apt-get again using the `/usr/bin/protoc` as the install folder.
@NoelStephensUnity
update
1636c28 
Trying a few things including using sudo.
@NoelStephensUnity
fix
14713cf 
Fixing some issues with my bad bash scripting.
Adjusting script to better reflect the status as well to verify the PROTOC path is correct.
@NoelStephensUnity
fix
5f470ec 
Fixing issue with spaces inbetween assignment of ThrewError.
Removing the which attempt.
@NoelStephensUnity
fix
2a18d32 
Making PROTOC the full path to the binary.
@NoelStephensUnity
update
ae5ebab 
Cleaning up the shell script additions.
Adding logMessage and logError in order to make messages easier to distinguish from the rest of the logs.
Removed the commented out script since this version seems to do the trick.
@NoelStephensUnity
update
5d04f80 
Replacing echo with logMessage and adding a few more progression logs.
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review August 13, 2025 23:21
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner August 13, 2025 23:21
@NoelStephensUnity NoelStephensUnity enabled auto-merge (squash) August 13, 2025 23:21
michalChrobot
michalChrobot approved these changes Aug 14, 2025
View reviewed changes
Copy link
Collaborator

@michalChrobot michalChrobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thanks a lot for fixing this

@NoelStephensUnity NoelStephensUnity merged commit 8292b0f into develop-2.0.0 Aug 14, 2025
25 checks passed
@NoelStephensUnity NoelStephensUnity deleted the chore/add-protobuffer-to-pre-install-before-building-service branch August 14, 2025 07:26
@sentinel-u3d sentinel-u3d bot requested a review from michalChrobot August 14, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalChrobot michalChrobot Awaiting requested review from michalChrobot

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NoelStephensUnity @michalChrobot