Skip to content

fix: Arm64 test failures #3619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 22, 2025
Merged

fix: Arm64 test failures #3619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e531211
Fixes some test failures when running against arm64:
ShadauxCat Aug 22, 2025
002ade1
Merge branch 'develop-2.0.0' into Arm64_test_fixes
NoelStephensUnity Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion com.unity.netcode.gameobjects/Tests/Runtime/NetworkVariable/NetworkVariableTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2901,7 +2901,7 @@ public void WhenSerializingAndDeserializingVeryLargeListNetworkVariables_ValuesA
public void WhenSerializingAndDeserializingVeryLargeHashSetNetworkVariables_ValuesAreSerializedCorrectly(

[Values(typeof(byte), typeof(sbyte), typeof(short), typeof(ushort), typeof(int), typeof(uint),
typeof(long), typeof(ulong), typeof(bool), typeof(char), typeof(float), typeof(double),
typeof(long), typeof(ulong), typeof(char), typeof(float), typeof(double),
typeof(Vector2), typeof(Vector3), typeof(Vector2Int), typeof(Vector3Int), typeof(Vector4),
typeof(Quaternion), typeof(Pose), typeof(HashableNetworkVariableTestClass), typeof(FixedString32Bytes))]
Type testType)
Expand Down
50 changes: 32 additions & 18 deletions ...nity.netcode.gameobjects/Tests/Runtime/NetworkVariable/NetworkVariableTestsHelperTypes.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,14 +187,13 @@ internal struct HashableNetworkVariableTestStruct : INetworkSerializeByMemcpy, I
public uint E;
public long F;
public ulong G;
public bool H;
public char I;
public float J;
public double K;
public char H;
public float I;
public double J;

public bool Equals(HashableNetworkVariableTestStruct other)
{
return A == other.A && B == other.B && C == other.C && D == other.D && E == other.E && F == other.F && G == other.G && H == other.H && I == other.I && J.Equals(other.J) && K.Equals(other.K);
return A == other.A && B == other.B && C == other.C && D == other.D && E == other.E && F == other.F && G == other.G && H == other.H && I.Equals(other.I) && J.Equals(other.J);
}

public override bool Equals(object obj)
Expand All @@ -215,7 +214,6 @@ public override int GetHashCode()
hashCode.Add(H);
hashCode.Add(I);
hashCode.Add(J);
hashCode.Add(K);
return hashCode.ToHashCode();
}
}
Expand All @@ -229,14 +227,18 @@ internal struct HashMapKeyStruct : INetworkSerializeByMemcpy, IEquatable<HashMap
public uint E;
public long F;
public ulong G;
public bool H;
public char I;
public float J;
public double K;
public char H;
public float I;
public double J;

public bool Equals(HashMapKeyStruct other)
{
return A == other.A && B == other.B && C == other.C && D == other.D && E == other.E && F == other.F && G == other.G && H == other.H && I == other.I && J.Equals(other.J) && K.Equals(other.K);
return A == other.A && B == other.B && C == other.C && D == other.D && E == other.E && F == other.F && G == other.G && H == other.H && I.Equals(other.I) && J.Equals(other.J);
}

public override string ToString()
{
return $"{{A: {A}, B: {B}, C:{C}, D:{D}, E:{E}, F:{F}, G:{G}, H:{H}, I:{I}, J:{J}}}";
}

public override bool Equals(object obj)
Expand All @@ -257,7 +259,6 @@ public override int GetHashCode()
hashCode.Add(H);
hashCode.Add(I);
hashCode.Add(J);
hashCode.Add(K);
return hashCode.ToHashCode();
}
}
Expand All @@ -271,14 +272,18 @@ internal struct HashMapValStruct : INetworkSerializeByMemcpy, IEquatable<HashMap
public uint E;
public long F;
public ulong G;
public bool H;
public char I;
public float J;
public double K;
public char H;
public float I;
public double J;

public bool Equals(HashMapValStruct other)
{
return A == other.A && B == other.B && C == other.C && D == other.D && E == other.E && F == other.F && G == other.G && H == other.H && I == other.I && J.Equals(other.J) && K.Equals(other.K);
return A == other.A && B == other.B && C == other.C && D == other.D && E == other.E && F == other.F && G == other.G && H == other.H && I.Equals(other.I) && J.Equals(other.J);
}

public override string ToString()
{
return $"{{A: {A}, B: {B}, C:{C}, D:{D}, E:{E}, F:{F}, G:{G}, H:{H}, I:{I}, J:{J}}}";
}

public override bool Equals(object obj)
Expand All @@ -299,7 +304,6 @@ public override int GetHashCode()
hashCode.Add(H);
hashCode.Add(I);
hashCode.Add(J);
hashCode.Add(K);
return hashCode.ToHashCode();
}
}
Expand Down Expand Up @@ -381,6 +385,11 @@ public override bool Equals(object obj)
return obj is HashMapKeyClass other && Equals(other);
}

public override string ToString()
{
return Data.ToString();
}

public override int GetHashCode()
{
return Data.GetHashCode();
Expand All @@ -401,6 +410,11 @@ public bool Equals(HashMapValClass other)
return Data.Equals(other.Data);
}

public override string ToString()
{
return Data.ToString();
}

public override bool Equals(object obj)
{
return obj is HashMapValClass other && Equals(other);
Expand Down