Skip to content

feat: server-enforced RpcInvokePermission and spoof prevention #3696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: develop-2.0.0
Choose a base branch
from
+193 −16
Open

feat: server-enforced RpcInvokePermission and spoof prevention #3696

Changes from 2 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
698fd2d
Secure RpcMessage against SenderClientId spoofing
xmanning Sep 27, 2025
0bc1f93
Merge branch 'develop-2.0.0' into develop-2.0.0
xmanning Sep 29, 2025
72f0e82
Replaced RequireOwnership with a new RpcInvokePermission
xmanning Oct 2, 2025
a0ade5b
Replaced RequireOwnership with a new RpcInvokePermission
xmanning Oct 2, 2025
fcfc662
Add missing switch case
xmanning Oct 2, 2025
eb0bea1
Merge branch 'develop-2.0.0' of https://github.com/xmanning/com.unity…
xmanning Oct 2, 2025
553f805
Another missing switch case
xmanning Oct 2, 2025
82a80db
Restore and deprecate RequireOwnership in favor of RpcInvokePermission
xmanning Oct 2, 2025
d4f3fec
Only do permission validations on server
xmanning Oct 2, 2025
2f27f80
Merge branch 'develop-2.0.0' into develop-2.0.0
EmandM Oct 7, 2025
087a2f7
ClientRpc properly assigned InvokePermission
xmanning Oct 7, 2025
9a29b29
Merge branch 'develop-2.0.0' of https://github.com/xmanning/com.unity…
xmanning Oct 7, 2025
edfd01b
Merge branch 'develop-2.0.0' into develop-2.0.0
xmanning Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions com.unity.netcode.gameobjects/Runtime/Messaging/Messages/RpcMessages.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,12 @@ public unsafe bool Deserialize(FastBufferReader reader, ref NetworkContext conte

public void Handle(ref NetworkContext context)
{
var networkManager = (NetworkManager)context.SystemOwner;
if (networkManager.IsServer)
{
SenderClientId = context.SenderId;
}

var rpcParams = new __RpcParams
{
Ext = new RpcParams
Expand Down