fix: Ensure NetworkConnectionManager correctly handles multiple disconnect messages being sent #3707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nnect messages being sent
EmandM
commented
Oct 7, 2025
com.unity.netcode.gameobjects/Runtime/Connection/NetworkConnectionManager.cs
Outdated
Show resolved
Hide resolved
EmandM
commented
Oct 7, 2025
EmandM
commented
Oct 7, 2025
EmandM
commented
Oct 7, 2025
com.unity.netcode.gameobjects/Tests/Runtime/TestHelpers/NetcodeIntegrationTest.cs
Outdated
Show resolved
Hide resolved
6 tasks
…/com.unity.netcode.gameobjects into fix/transport-double-disconnect
6 tasks
EmandM
added
port:1.x-completed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Ensure NetworkConnectionManager correctly handles multiple disconnect messages being sent.
Jira ticket
MTTB-1339
MTTB-1628
fixes: #2858
fixes: #3695
Changelog
NetworkManager.GetTransportIdFromClientIdandNetworkManager.GetClientIdFromTransportIdnow returnulong:MaxValuewhen the clientId or the transportId doesn't exist, rather than zero.Documentation
Testing & QA (How your changes can be verified during release Playtest)
Functional Testing
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Backports
Backported in #3721