-
Notifications
You must be signed in to change notification settings - Fork 458
docs: additional order of operations and switch transform space when parented updates #3716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
NoelStephensUnity
wants to merge
115
commits into
develop-2.0.0
Choose a base branch
from
doc/addition-to-3664-order-of-operations
base: develop-2.0.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
docs: additional order of operations and switch transform space when parented updates #3716
NoelStephensUnity
wants to merge
115
commits into
develop-2.0.0
from
doc/addition-to-3664-order-of-operations
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reset IsTeleporting and ExplicitSet after invoking OnAuthorityPushTransformState so these values are preserved for user script. Automatically adjust InLocalSpace when spawning a NeworkObject based on the NetworkObject's current parented status when SwitchTransformSpaceWhenParented is enabled.
…e-forcing-updates-localspace
…calspace' of https://github.com/Unity-Technologies/com.unity.netcode.gameobjects into fix/networktransform-autoswitchspace-forcing-updates-localspace
NetworkSpawnManager: Relative to spawning only, process deferred messages after post spawn. NetworkTransform: Synchronize the SwitchTransformSpaceWhenParented flag when it changes on the authority side. Perform an early check in CheckForStateChange for changes to SwitchTransformSpaceWhenParented. Apply changes to SwitchTransformSpaceWhenParented when processing a state update on non-authority instance.
…calspace' of https://github.com/Unity-Technologies/com.unity.netcode.gameobjects into fix/networktransform-autoswitchspace-forcing-updates-localspace
Co-authored-by: Amy Reeve <[email protected]>
…orm.cs Co-authored-by: Amy Reeve <[email protected]>
…orm.cs Co-authored-by: Amy Reeve <[email protected]>
…orm.cs Co-authored-by: Amy Reeve <[email protected]>
…e-forcing-updates-localspace
A complete refactoring of how parenting is handled when NetworkTransform.SwitchTransformSpaceWhenParented is enabled to provide a complete 1:1 match of (n) back-to-back parenting actions and/or many parenting actions that occur over several frames. This preserves the order of operations, sends 1 full state update plus an added parenting directive per action immediately, and then upon receiving the non-authority instances will apply the parenting, transform the local values and interpolators' queued entries between transform spaces (world to local, local to world, or local to local).
More hidden white spaces...
…e-forcing-updates-localspace
Co-authored-by: Amy Reeve <[email protected]>
Adjusting based on the PR's recent updates. Refactoring the physics section. Moved the NetworkRigidbody content out of physics and into a new NetworkRigidbody section under componetns. Moved physics up to the components layer. Did a large update to the physics documentation and provided an additional walk through of how to "parent" physics bodies using attachables.
…e-forcing-updates-localspace
…e-forcing-updates-localspace
This refactors the previous "fix" to preserve the teleport flag but also keeps the original logic which is needed for when SwitchTransformSpaceWhenParented is disabled.
…e-forcing-updates-localspace
This includes a more modular framework for generating order of operation sequences in order to create a wide range of tests that validate specific order of operation actions are processed and applied on the non-authority instances as they were on the authority instance.
…e-forcing-updates-localspace
Some general clean up and separating areas of the NetworkTransformOrderOfOperations by region to help with navigating through the different parts.
…e-forcing-updates-localspace
…e-forcing-updates-localspace
…e-forcing-updates-localspace
…calspace' into doc/addition-to-3664-order-of-operations
…calspace' into doc/addition-to-3664-order-of-operations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR is a documentation extension PR from #3664.
Jira ticket
MTTB-1584
MTT-10092
Changelog
Documentation Included
WIP Documentation
Testing & QA (How your changes can be verified during release Playtest)
Functional Testing
Manual testing :
Manual testing done
Automated tests:
Covered by existing automated tests
Covered by new automated tests
Does the change require QA team to:
Review automated tests
?Execute manual tests
?Provide feedback about the PR
?If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Backports
This PR is only for v2.x.