Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements encryption for LCID (Locale ID) values stored in player data using AES-256-GCM encryption. The changes enhance data security by ensuring LCID values are encrypted at rest and support lazy migration of existing plain text values.
Key Changes:
- Added AES-256-GCM encryption service for LCID values with encryption key stored in Secret Manager
- Modified PlayerDataService to encrypt LCIDs on storage and decrypt on retrieval, with automatic lazy migration for existing plain text values
- Added comprehensive unit tests for both encryption service and player data service encryption functionality
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| docs/SETUP.md | Added setup instructions for LCID encryption key in Secret Manager |
| Project/Interfaces/IEncryptionService.cs | Defines encryption service interface for encrypt, decrypt, and detection operations |
| Project/Services/AesEncryptionService.cs | Implements AES-256-GCM encryption service with key retrieval from Secret Manager |
| Project/Services/PlayerDataService.cs | Integrates encryption for LCID storage and retrieval with lazy migration support |
| Project/ModuleConfig.cs | Registers encryption service in dependency injection container |
| UnitTests/AesEncryptionServiceTests.cs | Comprehensive tests for encryption service including round-trip, error handling, and edge cases |
| UnitTests/PlayerDataServiceTests.cs | Tests for encrypted LCID storage, retrieval, and lazy migration functionality |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
JaredZanette-unity3d
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.