Merged
Conversation
|
|
![cycode-security[bot]](https://avatars.githubusercontent.com/in/39308?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull Request Overview
This PR updates the grpcio dependency version to support Apple M1 machines by expanding the upper version limit and removes outdated OS X installation instructions for grpc.
- Update grpcio version range to <=1.51.3 in ml-agents/setup.py and ml-agents-envs/setup.py
- Remove obsolete OS X GRPC library installation instructions from docs/Installation.md
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ml-agents/setup.py | Updated grpcio dependency version range for Apple M1 support |
| ml-agents-envs/setup.py | Synced grpcio dependency version update |
| docs/Installation.md | Removed outdated OS X GRPC installation instructions |
Comments suppressed due to low confidence (1)
docs/Installation.md:167
- The removal of the manual GRPC installation instructions is appropriate given the updated grpcio wheels; however, consider referencing this change in the upgrade notes or documentation to guide users upgrading from previous versions.
#### (OS X) Installing GRPC libraries [removed block]
alexander-suvorov
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Describe the changes made in this PR.
Upgrade grpcio Python binary wheels since grpcio 1.48.2 doesn't come with precompiled binaries to be used with Apple M1. Ref: grpc/grpc#34821 (comment)
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
Types of change(s)
Checklist
Other comments