Skip to content

Add PD controller for joint-space impedance#400

Open
urfeex wants to merge 2 commits intoUniversalRobots:masterfrom
urfeex:pd_controller
Open

Add PD controller for joint-space impedance#400
urfeex wants to merge 2 commits intoUniversalRobots:masterfrom
urfeex:pd_controller

Conversation

@urfeex
Copy link
Copy Markdown
Member

@urfeex urfeex commented Nov 4, 2025

Adds a joint space impedance controller to the driver.

@urfeex urfeex requested a review from a team November 4, 2025 15:33
@urfeex urfeex added the enhancement New feature or request label Nov 4, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 4, 2025

Codecov Report

❌ Patch coverage is 66.32653% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.52%. Comparing base (6ec1ee0) to head (c406900).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/ur/ur_driver.cpp 30.30% 22 Missing and 1 partial ⚠️
...ary/control/torque_command_controller_parameters.h 66.66% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #400      +/-   ##
==========================================
- Coverage   77.09%   73.52%   -3.57%     
==========================================
  Files         110      111       +1     
  Lines        5823     5938     +115     
  Branches     2576     2635      +59     
==========================================
- Hits         4489     4366     -123     
- Misses        996     1229     +233     
- Partials      338      343       +5     
Flag Coverage Δ
start_ursim 83.02% <ø> (-2.07%) ⬇️
ur20-latest 69.64% <61.22%> (-2.76%) ⬇️
ur5-3.14.3 ?
ur5e-10.11.0 63.11% <53.06%> (-3.00%) ⬇️
ur5e-10.12.0 64.19% <53.06%> (-3.24%) ⬇️
ur5e-10.7.0 62.51% <53.06%> (-3.04%) ⬇️
ur5e-5.9.4 65.43% <53.06%> (-7.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@urrsk urrsk force-pushed the pd_controller branch 3 times, most recently from 1c419fc to d16db5b Compare March 2, 2026 13:47
urrsk added 2 commits March 23, 2026 14:46
Extract the version-dependent direct_torque call logic from
torqueThread() into a standalone directTorqueControlCall(tau)
function. This allows reuse of the same logic in other control
threads without code duplication.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants