Skip to content

Conversation

@urmahp
Copy link
Contributor

@urmahp urmahp commented Nov 17, 2025

There is dashboard client support for PolyScopeX version 10.11.0 and above, so we should initialize it in the ExampleRobotWrapper when it is possible.

There is dashboard client support for PolyScopeX version 10.11.0 and above, so we should initialize it in the ExampleRobotWrapper when it is possible.
@urmahp urmahp requested a review from a team November 17, 2025 10:44
@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

❌ Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.70%. Comparing base (1d785d9) to head (7c1ef8c).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/example_robot_wrapper.cpp 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #409      +/-   ##
==========================================
- Coverage   42.87%   42.70%   -0.18%     
==========================================
  Files          99       99              
  Lines        8636     8637       +1     
  Branches     1171     1171              
==========================================
- Hits         3703     3688      -15     
- Misses       4654     4670      +16     
  Partials      279      279              
Flag Coverage Δ
start_ursim 82.22% <ø> (-2.45%) ⬇️
ur20-latest 40.70% <85.71%> (-0.07%) ⬇️
ur5-3.14.3 40.50% <85.71%> (-0.06%) ⬇️
ur5e-10.7.0 35.63% <11.11%> (-0.06%) ⬇️
ur5e-5.9.4 40.67% <85.71%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@urfeex urfeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@urmahp urmahp merged commit 8cb6517 into UniversalRobots:master Nov 17, 2025
22 of 28 checks passed
@urmahp urmahp deleted the initialize_dashboard_client branch November 17, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants