Skip to content

Primary power on improvements#473

Merged
urrsk merged 1 commit intoUniversalRobots:masterfrom
urrsk:primaryPowerOnImprovements
Mar 26, 2026
Merged

Primary power on improvements#473
urrsk merged 1 commit intoUniversalRobots:masterfrom
urrsk:primaryPowerOnImprovements

Conversation

@urrsk
Copy link
Copy Markdown
Member

@urrsk urrsk commented Mar 26, 2026

command power on would hang if the robot already was in running.
This commit with enable commandPowerOn to return successfully if the robot is in running as well as idle.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.76%. Comparing base (9c89565) to head (56b2197).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #473      +/-   ##
==========================================
- Coverage   76.89%   76.76%   -0.13%     
==========================================
  Files         110      110              
  Lines        5821     5824       +3     
  Branches     2576     2577       +1     
==========================================
- Hits         4476     4471       -5     
- Misses       1006     1014       +8     
  Partials      339      339              
Flag Coverage Δ
start_ursim 83.51% <ø> (-1.10%) ⬇️
ur20-latest 72.29% <100.00%> (+0.01%) ⬆️
ur5-3.14.3 72.09% <100.00%> (-0.12%) ⬇️
ur5e-10.11.0 65.78% <100.00%> (-0.09%) ⬇️
ur5e-10.12.0 67.21% <100.00%> (+0.03%) ⬆️
ur5e-10.7.0 65.19% <100.00%> (-0.13%) ⬇️
ur5e-5.9.4 72.81% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Now also accepts both idle and running is a valid return state
@urrsk urrsk force-pushed the primaryPowerOnImprovements branch from c9ee808 to 56b2197 Compare March 26, 2026 09:59
@urrsk urrsk requested a review from urfeex March 26, 2026 10:17
@urrsk urrsk marked this pull request as ready for review March 26, 2026 10:17
@urfeex urfeex added enhancement New feature or request bugfix and removed enhancement New feature or request labels Mar 26, 2026
@urrsk urrsk merged commit bd19a47 into UniversalRobots:master Mar 26, 2026
33 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants