Use pose_broadcaster to publish the TCP pose #1108
Conversation
|
High-level question: would it perhaps be better to have the hardware interface offer a quaternion instead of an Euler angle triplet? That would seem cleaner to me, in the sense of it being more of an While they aren't necessarily very human friendly, quaternions have definite benefits mathematically, and making it the responsibility of the hardware interface/driver to convert whatever internal orientation representation it uses to this 'intermediary representation' would seem to make sense. |
I was discussing that with @RobertWilbrandt, as well and I would agree. But I think that's a question to discuss once the PR on ros2_controllers is there. |
|
Oh, just noticed #856 actually does it that way. |
|
I don't have any strong opinions on this - Going through REP 103 i went through the options and preferred RPY because the values cannot represent any invalid state (while i would expect that a quaternion should be normalized). From an application point of view i agree, so i changed the representation in pose_broadcaster now. |
RobertWilbrandt
force-pushed
the
pose_broadcaster
branch
from
04edaaa to
4d453d8
Compare
# Conflicts: # ur_robot_driver/config/ur_controllers.yaml # ur_robot_driver/launch/ur_control.launch.py # ur_robot_driver/src/hardware_interface.cpp
This has now been merged to master.
Everything is merged upstream!
|
Binary builds fail as the necessary changes in ros2_control have just been merged into master. |
VinDp
left a comment
VinDp
left a comment
There was a problem hiding this comment.
Looks good to me and works as inteded.
urfeex
force-pushed
the
pose_broadcaster
branch
from
c8f3b35 to
7eb40c1
Compare
Adds a broadcaster for the robot's TCP pose. (cherry picked from commit 660e363)
Adds a broadcaster for the robot's TCP pose. (cherry picked from commit 660e363)
Adds a broadcaster for the robot's TCP pose.
Adds a broadcaster for the robot's TCP pose.
5 participants
This uses the PoseBroadcaster currently written by @RobertWilbrandt. As he wants to contribute that to ros2_controllers, this will stay in a draft state until it is merged upstream.