Allow setting the analog output domain when setting an analog output #1123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VinDp
approved these changes
Oct 8, 2024
Contributor
VinDp
left a comment
VinDp
left a comment
There was a problem hiding this comment.
Works as intended and looks good to me.
mergify bot
pushed a commit
that referenced
this pull request
Oct 8, 2024
(cherry picked from commit 8f2dfa9) # Conflicts: # ur_controllers/doc/index.rst # ur_robot_driver/urdf/ur.ros2_control.xacro
mergify bot
pushed a commit
that referenced
this pull request
Oct 8, 2024
(cherry picked from commit 8f2dfa9) # Conflicts: # ur_controllers/doc/index.rst # ur_robot_driver/urdf/ur.ros2_control.xacro
fmauch
pushed a commit
that referenced
this pull request
Oct 26, 2024
(cherry picked from commit 8f2dfa9) # Conflicts: # ur_controllers/doc/index.rst # ur_robot_driver/urdf/ur.ros2_control.xacro
fmauch
pushed a commit
that referenced
this pull request
Oct 26, 2024
(cherry picked from commit 8f2dfa9) # Conflicts: # ur_controllers/doc/index.rst # ur_robot_driver/urdf/ur.ros2_control.xacro
fmauch
pushed a commit
that referenced
this pull request
Oct 28, 2024
(cherry picked from commit 8f2dfa9) # Conflicts: # ur_controllers/doc/index.rst # ur_robot_driver/urdf/ur.ros2_control.xacro
fmauch
pushed a commit
that referenced
this pull request
Oct 28, 2024
(cherry picked from commit 8f2dfa9) # Conflicts: # ur_controllers/doc/index.rst # ur_robot_driver/urdf/ur.ros2_control.xacro
fmauch
pushed a commit
that referenced
this pull request
Oct 28, 2024
fmauch
pushed a commit
that referenced
this pull request
Oct 28, 2024
URJala
pushed a commit
to URJala/Universal_Robots_ROS2_Driver
that referenced
this pull request
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This basically implements a service for ros-industrial/ur_msgs#30