Skip to content

Conversation

@saikishor
Copy link
Contributor

This would be needed in order to have the controllers compiling with the future API of Handles with variants

@saikishor
Copy link
Contributor Author

@urfeex I believe the failing jobs are not related to this change

@urfeex
Copy link
Member

urfeex commented Feb 25, 2025

Thank you for providing this. Yes, the broken CI jobs are mainly due to #1275 and the big regression currently going on in the buildfarm. Nevertheless I would like to hold this back until things have normalized a bit. @saikishor is there an estimate from when the API we are currently use will be removed from rolling?

@saikishor
Copy link
Contributor Author

Thank you for providing this. Yes, the broken CI jobs are mainly due to #1275 and the big regression currently going on in the buildfarm. Nevertheless I would like to hold this back until things have normalized a bit. @saikishor is there an estimate from when the API we are currently use will be removed from rolling?

@urfeex I'm planning to add support for more types in ros2_control. You can find more info here : ros-controls/ros2_control#2065

As the default expects double, it is important that it is of the same type. Apart from this, nothing should change in your current setup

@urfeex urfeex merged commit b0f9c7a into UniversalRobots:main Mar 5, 2025
6 of 12 checks passed
@saikishor saikishor deleted the fix/types branch March 5, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants