Skip to content

Conversation

@urfeex
Copy link
Member

@urfeex urfeex commented Mar 4, 2025

The force torque is returned at the tool flange on e-series robots and at the tcp for CB3, this is now handled correctly, so that all force/torque measurements will be relative to the active TCP

@urfeex urfeex linked an issue Mar 4, 2025 that may be closed by this pull request
@urfeex urfeex requested review from URJala and urmahp March 4, 2025 14:39
@urfeex urfeex added backport-humble requires testing Requires some (hardware) testing labels Mar 5, 2025
@urfeex urfeex added this to the ROS1 feature parity milestone Mar 7, 2025
…es robot

The force torque is returned at the tool flange on e-series robots and
at the tcp for CB3, this is now handled correctly, so that all
force/torque measurements will be relative to the active TCP
@urfeex urfeex force-pushed the fix_fts_measurement_frame branch from f31f147 to 6dd3f30 Compare March 14, 2025 09:11
@codecov
Copy link

codecov bot commented Mar 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.

Project coverage is 5.66%. Comparing base (1b121b7) to head (6dd3f30).
Report is 406 commits behind head on main.

Files with missing lines Patch % Lines
ur_robot_driver/src/hardware_interface.cpp 0.00% 23 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1287      +/-   ##
========================================
+ Coverage   3.59%   5.66%   +2.07%     
========================================
  Files         13      31      +18     
  Lines        947    3072    +2125     
  Branches     152     375     +223     
========================================
+ Hits          34     174     +140     
- Misses       843    2896    +2053     
+ Partials      70       2      -68     
Flag Coverage Δ
unittests 5.66% <0.00%> (+2.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@URJala
Copy link
Collaborator

URJala commented Mar 14, 2025

Tested on robot, and it seems to work.

@urfeex urfeex merged commit 97e6b3d into UniversalRobots:main Mar 14, 2025
12 of 14 checks passed
@urfeex urfeex deleted the fix_fts_measurement_frame branch March 14, 2025 13:41
mergify bot pushed a commit that referenced this pull request Mar 14, 2025
…es robot (#1287)

The force torque is returned at the tool flange on e-series robots and
at the tcp for CB3, this is now handled correctly, so that all
force/torque measurements will be relative to the active TCP

(cherry picked from commit 97e6b3d)
urfeex pushed a commit that referenced this pull request Mar 17, 2025
…es robot (backport of #1287) (#1299)

The force torque is returned at the tool flange on e-series robots and
at the tcp for CB3, this is now handled correctly, so that all
force/torque measurements will be relative to the active TCP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-humble requires testing Requires some (hardware) testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Force-Torque measurements should be attached to correct frame

3 participants