Skip to content

Conversation

@mergify
Copy link

@mergify mergify bot commented Jun 25, 2025

The package compiles a library, but does not expose any symbol on Windows, so if the CMake project is compiled on on Windows, no library is actually generated.

On Linux and macOS, everything compiles by default all the symbols are visible. We can achieve exactly the same behavior in Windows by setting to ON the CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS CMake variable, so this PR sets the CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS variable to ON, to ensure that the compilation works fine on Windows.

Furthermore, the following fixes were also added:

  • -Wall -Wextra are GCC/Clang specific compilations options, so I moved it in an if for adding GCC/Clang specific compilations options.
  • uint does not exists in Windows, so we use uint32_t instead
  • The sleep function is not defined on Windows, so we use std::this_thread::sleep_for instead
    This is an automatic backport of pull request ur_robot_driver: Fix compilation on Windows #1421 done by Mergify.

@mergify mergify bot added the Jazzy label Jun 25, 2025
@urfeex urfeex merged commit 1096ec9 into jazzy Jun 25, 2025
5 of 6 checks passed
@urfeex urfeex deleted the mergify/bp/jazzy/pr-1421 branch June 25, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants