Skip to content

Conversation

@urfeex
Copy link
Member

@urfeex urfeex commented Jul 29, 2025

Using set could potentially block the RT thread.

Also, realtime_tools have changed their API regarding the set function not to accept a call by value to a pointer anymore, so we have to touch this anyway.

Using set could potentially block the RT thread.
@urfeex urfeex requested a review from URJala July 29, 2025 06:44
@urfeex urfeex added the bugfix label Jul 29, 2025
@urfeex urfeex mentioned this pull request Jul 29, 2025
@codecov
Copy link

codecov bot commented Jul 29, 2025

Codecov Report

❌ Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 5.10%. Comparing base (1b121b7) to head (7eb8281).
⚠️ Report is 476 commits behind head on main.

Files with missing lines Patch % Lines
ur_controllers/src/ur_configuration_controller.cpp 0.00% 11 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1470      +/-   ##
========================================
+ Coverage   3.59%   5.10%   +1.51%     
========================================
  Files         13      33      +20     
  Lines        947    3408    +2461     
  Branches     152     429     +277     
========================================
+ Hits          34     174     +140     
- Misses       843    3232    +2389     
+ Partials      70       2      -68     
Flag Coverage Δ
unittests 5.10% <0.00%> (+1.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@urfeex urfeex merged commit de22d32 into UniversalRobots:main Jul 29, 2025
9 of 14 checks passed
@urfeex urfeex deleted the ur_configuration_controller_try_set branch July 29, 2025 08:49
mergify bot pushed a commit that referenced this pull request Jul 29, 2025
* ur_configuration_controller: use try_set on RTBox

Using set could potentially block the RT thread.

* Remove temp variable

(cherry picked from commit de22d32)
urfeex pushed a commit that referenced this pull request Jul 29, 2025
…#1472)

* ur_configuration_controller: use try_set on RTBox

Using set could potentially block the RT thread.

* Remove temp variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants