Skip to content

Conversation

@urfeex
Copy link
Member

@urfeex urfeex commented Sep 5, 2025

Since speed scaling is merged in the upstream JTC, we dont't need to keep our SJTC implementation around any longer. For backwards comaptibility we might want to keep it a little longer as the parameters aren't exactly the same.

This PR effectively reduces the SJTC implementation to a translation of the state interface name parameter. This way, we directly use the upstream JTC, also when having the SJTC running.

Since speed scaling is merged in the upstream JTC, we dont't need to keep
our SJTC implementation around any longer. For backwards comaptibility we
might want to keep it a little longer as the parameters aren't exactly the
same.
@urfeex urfeex requested a review from a team September 5, 2025 06:53
@codecov
Copy link

codecov bot commented Sep 5, 2025

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 5.37%. Comparing base (1b121b7) to head (d225111).
⚠️ Report is 479 commits behind head on main.

Files with missing lines Patch % Lines
...rollers/src/scaled_joint_trajectory_controller.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1485      +/-   ##
========================================
+ Coverage   3.59%   5.37%   +1.78%     
========================================
  Files         13      33      +20     
  Lines        947    3239    +2292     
  Branches     152     391     +239     
========================================
+ Hits          34     174     +140     
- Misses       843    3063    +2220     
+ Partials      70       2      -68     
Flag Coverage Δ
unittests 5.37% <0.00%> (+1.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@urfeex urfeex requested a review from URJala September 5, 2025 13:24
@urfeex urfeex merged commit d1dd815 into UniversalRobots:main Sep 8, 2025
9 of 25 checks passed
@urfeex urfeex deleted the slim_out_sjtc branch September 8, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants