Temporarily deactivate one testcase in controller_switch_test #1553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test currently fails due to an upstream change. This should get addressed somehow, but for now this test case is disabled in order to not block other work.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1553 +/- ##
==========================================
+ Coverage 3.59% 16.53% +12.94%
==========================================
Files 13 34 +21
Lines 947 3587 +2640
Branches 152 451 +299
==========================================
+ Hits 34 593 +559
- Misses 843 2977 +2134
+ Partials 70 17 -53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
urmahp
approved these changes
Oct 30, 2025
mergify bot
pushed a commit
that referenced
this pull request
Oct 30, 2025
This test currently fails due to an upstream change. This should get addressed somehow, but for now this test case is disabled in order to not block other work. (cherry picked from commit 45496b8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test currently fails due to an upstream change. This should get addressed somehow, but for now this test case is disabled in order to not block other work.
See ros-controls/ros2_control#2758 for details about the issue. I don't know how that will be resolved and how long that will take. Since this is currently blocking the merge of #1546 and #1341 I would like to disable this check for now.
If this PR gets approved, I will create an issue that we should re-activate this.