Increase default dashboard client timeout to 2 seconds #1564
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default timeout of 1 second can collide with certain actions. For example, the power_off command on PolyScope 5 takes 1 sec almost exactly until it sends the answer. With that, the timeout was right on the edge and led to a flaky integration test. Defaulting to 2 seconds should prevent those tests from failing randomly.
I'll add this commit to #1561 and #1562 once approved.