-
Notifications
You must be signed in to change notification settings - Fork 305
Port robot_state_helper to ROS2 #933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
092af95 to
d0f0462
Compare
|
@fdurchdewald I hope you don't mind me coming back to this. As far as I remember you told me that there were still some unresolved problems with this, but I just rebased and tested this and it seems to to exactly what it is supposed to do. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #933 +/- ##
========================================
+ Coverage 3.59% 3.74% +0.15%
========================================
Files 13 397 +384
Lines 947 43840 +42893
Branches 152 6440 +6288
========================================
+ Hits 34 1640 +1606
- Misses 843 42057 +41214
- Partials 70 143 +73
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Tested on a real robot, and switching between Running and Idle seems to work well, but there are couple of things:
Otherwise it seems to work well with resuming and stopping programs. |
|
@URJala Thanks for testing this. I've refactored the code to address some of your findings.
That should be gone now.
I assume this is gone, as well, but I cannot test it currently.
To my knowledge, the dashboard server doesn't contain a "engage brakes" call. So, we have to go through power_off for that transition. Regarding stop and play: Did you read what I wrote into the documentation? |
|
Tested it again, and it seems to work perfectly now, couldnt find any of the problems from yesterday. |
--------- Co-authored-by: Felix Durchdewald <[email protected]> Co-authored-by: Felix Exner <[email protected]> (cherry picked from commit d4947aa) # Conflicts: # ur_robot_driver/CMakeLists.txt # ur_robot_driver/doc/index.rst # ur_robot_driver/doc/usage/startup.rst
--------- Co-authored-by: Felix Durchdewald <[email protected]> Co-authored-by: Felix Exner <[email protected]>
This pull request includes the 'robot_state_helper' node, which has been ported from the ROS1 to the ROS2 version of the driver.