Core & Optional Modules — Make UrbanMapper more lightweight!#82
Core & Optional Modules — Make UrbanMapper more lightweight!#82simonprovost merged 7 commits intomainfrom
Conversation
- Extras for Pre-Commit cleaning
297ce5c to
a144e69
Compare
fabiofelix
left a comment
There was a problem hiding this comment.
Hey @simonprovost, it seems like a good idea to separate these additional models from the main UM code. From my side, it could be merged. Let's wait for @soniacq reviews.
Brills! Thanks a bunch @fabiofelix, yup waiting for Sonia |
soniacq
left a comment
There was a problem hiding this comment.
Great contribution @simonprovost. The PR looks correct and adds great value in modularity and maintainability.
Just one comment: should we update the CI to distinguish core vs optional tests?
Thanks!
Thanks so much :) That’s a good point indeed. I think we can either leave it as is for now — if the CI gets too long in the future, we’ll already know how to improve it — or, alternatively, make the optional module tests run only when those modules are changed. What do you prefer? I don’t have strong preferences and I’m not sure how feasible it is, but I imagine it should be doable. Let me know :) Cheers |
soniacq
left a comment
There was a problem hiding this comment.
Yeah. That makes sense (second option). For now, we can leave it as is for now and proceed with the merge.
Thanks!
Hi @soniacq & @fabiofelix,
Finally had time to make optional modules in
UrbanMapper! As follows:pip install urbanmapper[auctus_mixin].Solving #79 !
Let me know if you have any changes for me to make please 🫡
Cheers