cnn #17
Open
cnn #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgoldbug
requested changes
Nov 4, 2025
Collaborator
bgoldbug
left a comment
bgoldbug
left a comment
There was a problem hiding this comment.
A few things:
- Move fakeram_asap7 directory from src into the respective asap7 design folder (you can rename it to srams, which is the generic naming for rams we have in the design folder)
- Move
generate_cnn_verilog.sh,replace_rams_with_fakeram.sh,requirements.txt, andsetup.shinto a new subdir calleddev, inside ofcnn/src - Update logic in bash files, it's failing to start the flow due to prior issues from the scripts
Collaborator
There was a problem hiding this comment.
We shouldn't need the clone repo logic here. We should add the repo as a submodule into src/cnn/dev instead.
Collaborator
There was a problem hiding this comment.
You should also initialize the venv if it doesn't exist.
Collaborator
There was a problem hiding this comment.
-setup.sh is called inside make (which is at the base folder of the ML_SUITE), so the current dir at this call would be UCSC_ML_suite/ rather than the intended UCSC_ML_suite/designs/src/cnn/dev
-I recommend getting the absolute path of the directory containing the bash scripts, and using that dir to call the script, instead of .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.