Skip to content

Conversation

@EstelleDa
Copy link
Member

Base automatically changed from release-2024.4.2 to main November 21, 2024 22:55
@bencap bencap changed the base branch from main to release-2024.4.3 November 21, 2024 23:01
@EstelleDa EstelleDa requested a review from jstone-dev December 3, 2024 10:46
Copy link
Collaborator

@bencap bencap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes Estelle! Would you also be able to add a couple tests for the newly searchable meta analysis field? It might require a new meta analysis score set to be added to the test DB.

)


# TODO: Rewrite this function.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets retain this function-- I think it still has utility for just listing all experiments.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I'll modify it so that we don't need to send the weird q to it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is ok to just leave it as is for this PR so we can get it released. We can just handle it at some point later-- it isn't hurting anything right now.

@bencap bencap changed the base branch from release-2024.4.3 to release-2024.4.4 December 10, 2024 22:36
Copy link
Collaborator

@bencap bencap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay on this Estelle, looks good!

@EstelleDa EstelleDa merged commit dd239e0 into release-2024.4.4 Jan 13, 2025
5 checks passed
@EstelleDa EstelleDa deleted the estelle/excludeMetaAnalysisExperiment branch January 13, 2025 02:27
@bencap bencap mentioned this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Experiment dropdown during score set creation should exclude meta-analysis experiments

3 participants