Include score and counts column metadata fields on ScoreSetCreator and ScoreSetEditor components #540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug related to issue described here: primefaces/primevue#5601 For the dropdown to work as expected, the suggestions array must be mutated even when there is no filter being applied. Also removes unneeded computed property for suggestions list.
…periment creator components
…nt save function.
…reSetCreator component This button was being shown regardless of the context, now will only be displayed when the selected target accession could be converted to a protein accesion.
Fixing component name and removing parts of ScoreSetCreator component that were based on having an existing item loaded, which should not be the case when creating a new score set. These appear to be artifact from copying the ScoreSetEditor component. Also updated the resetForm function to clear all form values, validation errors, and reset the active step to 0. Remove save button from form header area, to only allow saving from last step of wizard.
…ScoreSetCreator Updates to align ScoreSetEditor content and functionality with current use, which is for editing existing score sets. Removes formatting and functionality related to creating new score sets which is now in ScoreSetCreator. Renamed "Clear" button to "Reset" to more accurately describe its function in this context.
…set and experiment editor components
…to null, so that merged validation errors object passes the isEmpty check
…d viewer dialog, view and delete button
Includes handling of scoreColumnsMetadataFile and countColumnsMetadataFile form inputs, parsing to JSON and passing with request body on save as part of datasetColumns field of score set record. Also adds view and delete buttons to corresponding form elements when values are present, to behave similar to extraMetadata form field.
… score and counts column metadata when saving To match changes made in ScoreSetEditor for the same fields, ScoreSetCreator will now parse uploaded files for score and count column metadata and submit as part of datasetColumns field of new record. Also cleans up some remaining references to `this.item`, which is only applicable for ScoreSetEditor and isn't used when creating new score sets.
…iants PATCH endpoint Updating ScoreSetEditor to use score-set=with-variants PATCH endpoint to combine submission of score set and variants data into a single request. Combines form data and files into multi-part form data payload. Eliminates need to form data with existing record for updates, only fields included in payload will be updated.
…rors generated via model_validate instead of fast api's pydantic validation
… variants/data POST request on ScoreSetCreator component
bencap
reviewed
Nov 4, 2025
Collaborator
bencap
left a comment
bencap
left a comment
There was a problem hiding this comment.
Thanks for the changes and the housekeeping @davereinhart, I had no idea the creator file had so much obsolete duplication from the editor.
Given that we expect the metadata file to evolve, I don't think it's essential we render metadata in the UI as part of this task, but we should add another issue for it and start thinking about what that might look like. Another issue for adding a download button would be good as well in the interim and is probably all we need for a little while at least.
There was one blocking bug I found in the case statement that was causing the score metadata to be set as the same thing as the count metadata if the count metadata was set after the score metadata, but it should be a trivial fix. After that is all set this looks good.
… text to address PR comments
davereinhart
force-pushed
the
davereinhart/scoreset-column-metadata
branch
from
87850d4 to
49f415e
Compare
bencap
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to correspond with API changes to include score and count columns metadata as inputs on ScoreSetCreator and ScoreSetEditor, and transition from PUT to PATCH endpoint for ScoreSetEditor. With this change, user can upload JSON file for score and/or count column metadata which is parsed to JSON client side and submitted with score and count CSV files as part of multipart form data payload.
Goes with VariantEffect/mavedb-api#546