Skip to content

Include score and counts column metadata fields on ScoreSetCreator and ScoreSetEditor components #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bencap merged 19 commits into from
Nov 10, 2025
Merged

Include score and counts column metadata fields on ScoreSetCreator and ScoreSetEditor components #540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
f8224db
Fix accession selection AutoComplete component bug
davereinhart Sep 25, 2025
9389188
Add .vscode folder to gitignore
davereinhart Sep 25, 2025
0d644c0
Restrict file upload widgets by expected MIME type on scoreset and ex…
davereinhart Sep 25, 2025
0318bc5
Fix logic for handling validation errors in ExperimentCreator compone…
davereinhart Sep 25, 2025
65a557d
Add function to show/hide "Switch to Protein Accession" button on Sco…
davereinhart Sep 26, 2025
fedcafe
Add score and count column metadata file uploads to ScoreSetCreator c…
davereinhart Sep 26, 2025
63fcc5d
Remove ScoreSetEditor artifacts from ScoreSetCreator component
davereinhart Sep 26, 2025
03cdf53
Scrub ScoreSetEditor component of functionality and content moved to …
davereinhart Sep 26, 2025
f5a2fab
Restrict file types for upload widgets by setting MIME type in score…
davereinhart Sep 29, 2025
e7b066d
Add score and count column metadata file uploads to ScoreSetEditor co…
davereinhart Sep 29, 2025
79bce34
Keys must be deleted from clientSideValidationErrors rather than set …
davereinhart Sep 29, 2025
258f337
Update ScoreSetEditor to properly handle extraMetadata field, plus ad…
davereinhart Sep 30, 2025
540b510
Update ScoreSetEditor component to set datasetColumns on save
davereinhart Oct 1, 2025
462873e
Additional changes to ScoreSetCreator to parse files for, and include…
davereinhart Oct 1, 2025
0c41783
Updates to ScoreSetEditor component to utilize new score-set=with-var…
davereinhart Oct 20, 2025
7b44106
Camelcase error location paths on ScoreSetEditor to handle request er…
davereinhart Oct 29, 2025
9cce4fa
Submit score and count columns metadata JSON as part of form data for…
davereinhart Oct 29, 2025
49f415e
Copy/paste error fixes and update to score/count column metadata help…
davereinhart Nov 5, 2025
61ef22b
Readd router link for experiment on ScoreSetCreator component, when p…
davereinhart Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,5 +132,8 @@ venv.bak/
# Sphinx documentation build cache
.doctrees/

# IDEs and editors
.vscode/

# OS X folder view option files
*.DS_Store
6 changes: 3 additions & 3 deletions src/components/screens/ExperimentCreator.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,6 +357,7 @@
<span class="p-float-label">
<FileUpload
:id="scopedId('input-extraMetadataFile')"
accept="application/json"
:auto="false"
choose-label="Extra metadata"
:class="inputClasses.extraMetadataFile"
Expand Down Expand Up @@ -1054,7 +1055,7 @@ export default {
this.clientSideValidationErrors.extraMetadata =
'Extra metadata must be a JSON object (not an array or simple value).'
} else {
this.clientSideValidationErrors.extraMetadata = null
delete this.clientSideValidationErrors.extraMetadata
}
} catch {
this.extraMetadata = null
Expand Down Expand Up @@ -1237,6 +1238,7 @@ export default {
this.$toast.add({severity: 'success', summary: 'The new experiment was saved.', life: 3000})
}
} else if (response.data && response.data.detail) {
this.serverSideValidationErrors = {}
if (typeof response.data.detail === 'string' || response.data.detail instanceof String) {
// Handle generic errors that are not surfaced by the API as objects
this.$toast.add({
Expand All @@ -1254,9 +1256,7 @@ export default {
formValidationErrors[path] = error.msg
}
this.serverSideValidationErrors = formValidationErrors
this.mergeValidationErrors()
}
this.serverSideValidationErrors = formValidationErrors
this.mergeValidationErrors()
this.activeWizardStep = this.minStepWithError()
}
Expand Down
3 changes: 2 additions & 1 deletion src/components/screens/ExperimentEditor.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,7 @@
<span class="p-float-label">
<FileUpload
:id="scopedId('input-extraMetadataFile')"
accept="application/json"
:auto="false"
choose-label="Extra metadata"
:class="inputClasses.extraMetadataFile"
Expand Down Expand Up @@ -826,7 +827,7 @@ export default {
this.clientSideValidationErrors.extraMetadata =
'Extra metadata must be a JSON object (not an array or simple value).'
} else {
this.clientSideValidationErrors.extraMetadata = null
delete this.clientSideValidationErrors.extraMetadata
}
} catch {
this.extraMetadata = null
Expand Down
Loading