fix: update test optimizer bundle path and content #1358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
erickzanardo
approved these changes
Sep 11, 2025
Merged
meylis1998
added a commit
to meylis1998/very_good_cli
that referenced
this pull request
Jan 12, 2026
Fixes VeryGoodOpenSource#1360 The previous CI verification using `git diff` could not detect new untracked files added to the brick. This caused PR VeryGoodOpenSource#1344 to pass CI with a stale bundle, which was later discovered in PR VeryGoodOpenSource#1358. Changes: - Replace simple `git diff` with comprehensive two-part verification - Check for both modifications AND untracked/deleted bundle files - Add bundle file path to workflow triggers for direct changes - Improve error messages with clear remediation steps The new verification now catches: - Modified brick files (existing behavior) - New brick files added (NEW - fixes the bug) - Deleted brick files (existing behavior) - Incorrect output paths (NEW) - Direct bundle modifications (improved) This ensures the committed bundle always matches what the current brick source would generate, preventing silent bundle drift.
6 tasks
marcossevilla
pushed a commit
that referenced
this pull request
Jan 14, 2026
Fixes #1360 The previous CI verification using `git diff` could not detect new untracked files added to the brick. This caused PR #1344 to pass CI with a stale bundle, which was later discovered in PR #1358. Changes: - Replace simple `git diff` with comprehensive two-part verification - Check for both modifications AND untracked/deleted bundle files - Add bundle file path to workflow triggers for direct changes - Improve error messages with clear remediation steps The new verification now catches: - Modified brick files (existing behavior) - New brick files added (NEW - fixes the bug) - Deleted brick files (existing behavior) - Incorrect output paths (NEW) - Direct bundle modifications (improved) This ensures the committed bundle always matches what the current brick source would generate, preventing silent bundle drift.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Tool provided for generating the test optimizer bundle have wrong path was generating into wrong directory.
The change in generated bundle is because of changes #1344 where new bundle wasnt generated
Type of Change