Skip to content

Add ruby 3.4 Support #2189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joelhawksley merged 5 commits into from
Jan 6, 2025
Merged

Add ruby 3.4 Support #2189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
56409c1
add ruyb 3.4
Jan 6, 2025
446844e
add changelog entry
Jan 6, 2025
590b535
fix spec
Jan 6, 2025
5c1fde6
fix spec
Jan 6, 2025
41c4acc
fix specs for ruby-main
Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,12 @@ jobs:
- ruby_version: "3.3"
rails_version: "8.0"
mode: "capture_patch_enabled"
- ruby_version: "3.4"
rails_version: "8.0"
mode: "capture_patch_disabled"
- ruby_version: "3.4"
rails_version: "8.0"
mode: "capture_patch_enabled"
- ruby_version: "head"
rails_version: "main"
mode: "capture_patch_disabled"
Expand Down
4 changes: 4 additions & 0 deletions docs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ nav_order: 5

*Joel Hawksley*

* Add ruby 3.4 support to CI.

*Reegan Viljoen*

## 3.21.0

* Updates testing docs to include an example of how to use with RSpec.
Expand Down
2 changes: 1 addition & 1 deletion test/sandbox/test/rendering_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ def test_render_inline_allocations
MyComponent.ensure_compiled

allocations = (Rails.version.to_f >= 8.0) ?
{"3.4.0" => 110, "3.3.6" => 129} :
{"3.5.0" => 117, "3.4.1" => 117, "3.3.6" => 129} :
{"3.3.6" => 120, "3.3.0" => 120, "3.2.6" => 118, "3.1.6" => 118, "3.0.7" => 127}

assert_allocations(**allocations) do
Expand Down
Loading