Add ruby 3.4 Support #2189
Merged
Add ruby 3.4 Support #2189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 6, 2025 08:10
Collaborator
Author
|
@joelhawksley to reduce the size of the matrix we may want to also remove unsupported rubies(i.e 3.0) |
added 3 commits
January 6, 2025 08:24
Spone
approved these changes
Jan 6, 2025
Collaborator
Agreed! |
Member
|
@Spone @reeganviljoen agreed! We are going to formally drop support for unsupported rubies in v4: #2102 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Add ruby 3.4 Support
What approach did you choose and why?
Add ruby 3.4 to matrix
Anything you want to highlight for special attention from reviewers?
We should start looking into how chilled strings will affect view_component and possibly start to investigate any warnings from them