VCST-4834: Use platform delete confirmation dialog for fulfillment centers#160
VCST-4834: Use platform delete confirmation dialog for fulfillment centers#160
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
src/VirtoCommerce.InventoryModule.Web/Scripts/blades/fulfillment-center-list.js
Outdated
Show resolved
Hide resolved
vc-ci
left a comment
vc-ci
left a comment
There was a problem hiding this comment.
Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 8.519
Timestamp: 26-03-2026T16:03:29
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| } | ||
| } | ||
| dialogService.showConfirmationDialog(dialog); | ||
| dialogService.showDeleteConfirmationDialog(dialog); |
There was a problem hiding this comment.
List view passes name instead of count to dialog
Medium Severity
The list view delete dialog passes name: item.name, making it behave identically to the detail view. Per the PR description and test plan, the list view dialog is supposed to show a fulfillment center count. The new fulfillment-center localization key (e.g., "{{count}} fulfillment center(s)") was added across all 13 locale files specifically for this purpose, but is never referenced by the JavaScript code. The dialog likely needs a count property and a reference to the fulfillment-center translation key instead of (or in addition to) name.
Additional Locations (1)
🧪 Katalon Test Report — ✅ PASSED
Pass rate: 📋 Suite details
|
|
🧪 Katalon Test Report — ✅ PASSED
Pass rate: 📋 Suite details
|
2 participants
Description
showConfirmationDialogwithshowDeleteConfirmationDialogin both list and detail viewsfulfillment-centercount localization key across all 13 languagesTest plan
References
QA-test:
Jira-link:
https://virtocommerce.atlassian.net/browse/VCST-4834
Artifact URL:
https://vc3prerelease.blob.core.windows.net/packages/VirtoCommerce.Inventory_3.1001.0-pr-160-bfbe.zip
Note
Low Risk
Low risk UI-only change that swaps the delete confirmation modal implementation and adds a
namefield to the dialog model; deletion behavior and API calls are unchanged.Overview
Switches fulfillment center deletion prompts in both list and detail blades from
showConfirmationDialogto the platformshowDeleteConfirmationDialog.Adds a
namefield to the dialog payload (item.name/blade.currentEntity.name) so the delete confirmation can display the target entity context.Written by Cursor Bugbot for commit bfbeb66. This will update automatically on new commits. Configure here.