Skip to content

VCST-4834: Use platform delete confirmation dialog for fulfillment centers #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
basilkot wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

VCST-4834: Use platform delete confirmation dialog for fulfillment centers #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
acda9a3
Use platform delete confirmation dialog for fulfillment centers
basilkot Mar 26, 2026
f3c7522
Only one fulfillment can be deleted
basilkot Mar 26, 2026
bfbeb66
remove unused localization key
basilkot Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/VirtoCommerce.InventoryModule.Web/Scripts/blades/fulfillment-center-detail.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ angular.module('virtoCommerce.inventoryModule')
id: "confirmDelete",
title: "inventory.dialogs.fulfillment-delete.title",
message: "inventory.dialogs.fulfillment-delete.message",
name: blade.currentEntity.name,
callback: function (remove) {
if (remove) {
blade.isLoading = true;
Expand All @@ -130,7 +131,7 @@ angular.module('virtoCommerce.inventoryModule')
}
}
};
dialogService.showConfirmationDialog(dialog);
dialogService.showDeleteConfirmationDialog(dialog);
}

blade.onClose = function (closeCallback) {
Expand Down
3 changes: 2 additions & 1 deletion src/VirtoCommerce.InventoryModule.Web/Scripts/blades/fulfillment-center-list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ angular.module('virtoCommerce.inventoryModule')
id: "confirmDelete",
title: "inventory.dialogs.fulfillment-delete.title",
message: "inventory.dialogs.fulfillment-delete.message",
name: item.name,
callback: function (remove) {
if (remove) {
blade.isLoading = true;
Expand All @@ -86,7 +87,7 @@ angular.module('virtoCommerce.inventoryModule')
}
}
}
dialogService.showConfirmationDialog(dialog);
dialogService.showDeleteConfirmationDialog(dialog);
Copy link
Copy Markdown

@cursor cursor bot Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

List view passes name instead of count to dialog

Medium Severity

The list view delete dialog passes name: item.name, making it behave identically to the detail view. Per the PR description and test plan, the list view dialog is supposed to show a fulfillment center count. The new fulfillment-center localization key (e.g., "{{count}} fulfillment center(s)") was added across all 13 locale files specifically for this purpose, but is never referenced by the JavaScript code. The dialog likely needs a count property and a reference to the fulfillment-center translation key instead of (or in addition to) name.

Additional Locations (1)
Fix in Cursor Fix in Web

}

// simple and advanced filtering
Expand Down
Loading