update mrapp for cleanup and garbage collection#669
Draft
update mrapp for cleanup and garbage collection#669
Conversation
Signed-off-by: hanbollar <github@hannahbollar.com>
|
Your Render PR Server URL is https://examples-mrjs-pr-669.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cp40soe3e1ms73choh2g. |
Signed-off-by: hanbollar <github@hannahbollar.com>
Signed-off-by: hanbollar <github@hannahbollar.com>
Signed-off-by: hanbollar <github@hannahbollar.com>
Signed-off-by: hanbollar <github@hannahbollar.com>
3 tasks
Signed-off-by: hanbollar <github@hannahbollar.com>
Signed-off-by: hanbollar <github@hannahbollar.com>
Contributor
Author
|
need to fix 'enter/exit' MR issue - otherwise it's ready to go |
Contributor
Author
|
swapping this back to |
Contributor
Author
|
cant swap - should keep sub-main as itself and then merge that in after this pr since that's still before the big refactor / breaking change |
Contributor
Author
|
since we're paused and this is really outdated - turning this into a draft for viewing, but we'll prob redo this / not need this in a bit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linking
Related to #677
Fixes #678
Problem
Description of the problem including potential code and/or screenshots as an example
Solution
Quick explanation of change to be done
Breaking Change
If this is a breaking change describe the before and after and why the change was necessary
Required to Merge
[ ] VIDEO - if this pr changes something visually - post a video here of it in headset-MR and/or on desktop (depending on what it affects) for the reviewer to reference.[ ] BREAKING CHANGE@lobau@hanbollar