create material utils to clone off of for cleaner setup#670
Merged
create material utils to clone off of for cleaner setup#670
Conversation
Signed-off-by: hanbollar <github@hannahbollar.com>
Signed-off-by: hanbollar <github@hannahbollar.com>
|
Your Render PR Server URL is https://examples-mrjs-pr-670.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cp42i9un7f5s739e2mm0. |
3 tasks
Contributor
Author
|
small - so merging |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linking
related to #669
Problem
reduce number of overall programs and materials being used in a scene (reduce number of draw calls per renderpass)
Solution
temporary pass to reduce number of overall unique new materials - going to do a cleaner/bigger version of this when we add in a MaterialsManager to actually cache re-used materials better.
Breaking Change
nope
Notes
...
Required to Merge
- [ ] VIDEO - if this pr changes something visually - post a video here of it in headset-MR and/or on desktop (depending on what it affects) for the reviewer to reference.- [ ] BREAKING CHANGE@lobau@hanbollar