fix: new resurgence, relics, and event data #752
Conversation
WalkthroughAdds numerous localization entries: Hildryn Prime and Wisp Prime store items, void projection relic entries (T1–T4) for Wisp/Hildryn combos, Prime bobbleheads, Mega Prime Vault packs, several calendar/upgrade strings, renames one Exilus entry, plus a new mission type (MT_ENDLESS_CAPTURE) and a new sol node (DeimosHub). Changes
Sequence Diagram(s)(omitted — changes are data/localization additions and do not alter control flow) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (3)
data/languages.json(26 hunks)data/missionTypes.json(1 hunks)data/solNodes.json(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: SlayerOrnstein
Repo: WFCD/warframe-worldstate-data PR: 588
File: data/languages.json:18862-18865
Timestamp: 2024-12-17T20:05:33.832Z
Learning: In `data/languages.json`, upgrade descriptions should remain as provided by Digital Extremes (DE) without modifying formatting inconsistencies.
📚 Learning: 2024-12-17T20:05:33.832Z
Learnt from: SlayerOrnstein
Repo: WFCD/warframe-worldstate-data PR: 588
File: data/languages.json:18862-18865
Timestamp: 2024-12-17T20:05:33.832Z
Learning: In `data/languages.json`, upgrade descriptions should remain as provided by Digital Extremes (DE) without modifying formatting inconsistencies.
Applied to files:
data/languages.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Summary
🔇 Additional comments (12)
data/missionTypes.json (1)
76-79: Well-formatted addition that follows existing conventions.The new
MT_ENDLESS_CAPTUREentry for "Legacyte Harvest" is correctly added with proper JSON syntax, consistent naming convention (MT_*prefix), and proper placement in the file structure.data/solNodes.json (1)
1267-1271: Correctly structured relay hub entry following established patterns.The new
DeimosHubentry for "Necralisk (Deimos)" is properly formatted with consistent naming (*Hubpattern matchingZarimanHub), appropriate metadata ("Tenno"enemy and"Relay"type matching other hubs), and logical placement within the Deimos node cluster. JSON syntax is valid.data/languages.json (10)
32-43: Prime warframe and void projection entries look good.The new Hildryn Prime and Wisp Prime warframe entries, along with their associated void projection relic entries (hunks 2-4), follow the established naming and formatting conventions used in the file for other Prime warframes.
161-232: Noggle statue entries are correctly formatted.The new bobblehead/Noggle statue entries for Hildryn Prime and Wisp Prime follow the same naming pattern and formatting as existing collectible entries.
248-250: Shade Prime Sentinel entry is consistent.The new Shade Prime Sentinel entry follows the established pattern for sentinel entries in the file.
419-427: Prime Syandana and weapon entries are well-formatted.The new Prime syandana and weapon entries (Fulmin Prime, Gunsen Prime, Surator Prime Syandana, Entheor Prime Syandana) maintain consistency with existing entries.
501-528: Calendar challenge entries follow expected format.The new calendar challenge entries ("Starve the beast", "By The Blade") follow the pattern used in existing challenge definitions with consistent value/desc structure.
15436-15437: Exilus Adapter terminology update is sensible.Updating
/lotus/types/items/miscitems/utilityunlockerfrom "Exilus Adapter" to "Exilus Warframe Adapter" correctly distinguishes this from the new WeaponUtilityUnlocker entry (hunk 12), which is labeled "Exilus Weapon Adapter". This clarification aligns with the PR objective to fix adapter descriptions for their respective counterparts.
617-619: WeaponUtilityUnlocker entry is correctly added.The new entry for WeaponUtilityUnlocker with value "Exilus Weapon Adapter" correctly distinguishes weapon adapters from warframe adapters, providing appropriate terminology clarity.
647-697: Mega Prime Vault package entries are properly formatted.The new entries for MPVClearvoyPrimeSuit, MPVHeimtPrimeSentAccessories, MPVHildrynPrimeSinglePack, MPVLarkspurGravimag, MPVWispHildrynPrimeDualPack, and MPVWispPrimeSinglePack all follow the established naming and formatting patterns for Mega Prime Vault packages.
790-793: Calendar upgrade entry is consistently formatted.The new MagnetStatusPull entry ("Force Of Attraction") follows the established pattern for calendar upgrade definitions with both value and desc fields.
19302-19427: Archimedea challenge modifiers are generally well-structured.The bulk of new Archimedea challenge modifier entries follow the expected pattern with descriptive names and gameplay mechanics. The formatting and structure are consistent with existing challenge entries, though note the spelling issues flagged separately (throughtout, extra space).
Based on learnings: Per your previous feedback, descriptions should remain as provided by Digital Extremes. All descriptions here appear to be game-authored content and are correctly preserved.
ADHD brain fo brrrr
TobiTenno
changed the title
|
🎉 This PR is included in version 3.1.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What did you fix?
Added langs for prime resurgence items, archimedea challenges, calendar challenges, deimos hub node, legacyte mission type and fixed
Exilus Adapterdescription for its Warframe counterpartReproduction steps
Evidence/screenshot/link to line
Considerations
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.