Adds save dirty checking event #647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AustinShalit
force-pushed
the
feat/saveDirtyCheckEvent
branch
from
9b30396 to
cff7fb9
Compare
Current coverage is 57.73% (diff: 60.00%)@@ master #647 diff @@
==========================================
Files 194 195 +1
Lines 6060 6078 +18
Methods 0 0
Messages 0 0
Branches 551 554 +3
==========================================
+ Hits 3497 3509 +12
- Misses 2400 2406 +6
Partials 163 163
|
Member
|
This is a good opportunity to implement Undo/Redo as well |
Member
Author
|
@SamCarlberg Take a look at #359. Undo/Redo is for another day... |
| import java.util.Optional; | ||
|
|
||
| import javafx.beans.property.SimpleBooleanProperty; | ||
| import javafx.beans.value.ChangeListener; |
Member
There was a problem hiding this comment.
JavaFX shouldn't be available in the core because it's not on the RoboRio. I don't know why this even compiles.
Can you check the build.gradle to see why you can even import javafx from within the core.
Member
There was a problem hiding this comment.
JavaFX is bundled in the desktop JRE, so it compiles fine. Project Jigsaw solves this, but it's getting released in March...
AustinShalit
force-pushed
the
feat/saveDirtyCheckEvent
branch
from
542c4d2 to
cc5620c
Compare
AustinShalit
force-pushed
the
feat/saveDirtyCheckEvent
branch
from
cc5620c to
9d52740
Compare
Member
|
LGTM |
Member
Author
|
GTG |
AustinShalit
added a commit
to AustinShalit/GRIP
that referenced
this pull request
Aug 2, 2016
AustinShalit
added a commit
to AustinShalit/GRIP
that referenced
this pull request
Aug 2, 2016
AustinShalit
added a commit
to AustinShalit/GRIP
that referenced
this pull request
Aug 2, 2016
AustinShalit
added a commit
that referenced
this pull request
Aug 2, 2016
Fix bug introduced in #647
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #359
#359 & adds "Edited" to the title bar when the project is dirty.