Conversation
There was a problem hiding this comment.
Pull request overview
This PR finalizes the PHP 8.5 runtime baseline by adding an idempotent migration for the user_logs table, syncing canonical schema artifacts, and hardening a view partial to prevent PHP 8.5 warnings in the account edit flow. The changes address infrastructure gaps and PHP 8.5 compatibility issues discovered during deployment verification.
Changes:
- Added idempotent migration to ensure
user_logstable exists with proper foreign key constraints - Synced canonical schema artifacts (schema.sql and table_schema cache)
- Hardened tag subscription user listing partial with defensive null checks
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| db/migrate/20260218221000_ensure_user_logs_table_exists.php | New idempotent migration to create user_logs table and FK constraint if missing |
| db/schema.sql | Added user_logs table definition and foreign key constraint to canonical schema |
| db/table_schema/production/user_logs.php | Added/updated table schema cache with normalized formatting |
| app/views/tag_subscription/_user_listing.php | Added defensive null checks for user variables to prevent PHP 8.5 warnings |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Related Features / Issues
Overview of Changes
This PR closes PROJ-1 by finalizing PHP 8.5 runtime baseline stability with verified QA and deploy evidence.
Implemented fixes:
user_logstable exists:db/migrate/20260218221000_ensure_user_logs_table_exists.phpdb/schema.sqldb/table_schema/production/user_logs.phpapp/views/tag_subscription/_user_listing.phpQA / Verification
composer run ci:lint: passcomposer run test: pass (15 tests / 72 assertions)composer run analyse: pass (project script skipped: no phpstan config)composer run cs-check: pass (project script skipped: no php-cs-fixer config)composer run assets:verify: passGET /-> 200GET /post-> 200GET /post/show/1-> 404 (expected on empty dataset; no fatal)GET /help-> 200GET /static/more-> 200GET /user/login-> 200GET /user/editanonymous -> 302POST /user/authenticate(qa user) -> 302GET /user/editauthenticated -> 200user_logstable + FKfk_user_logs__user_idpresentDeployment Impact
user_logstable.Reviewer Focus
app/views/tag_subscription/_user_listing.phpunder PHP 8.5 warning/error behavior.Checklist