Skip to content

Bump the CI LLVM version to 21 #8223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stevenfontanella merged 2 commits into from
Jan 22, 2026
Merged

Bump the CI LLVM version to 21 #8223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e785dd3
Try bumping LLVM version
stevenfontanella Jan 21, 2026
8366316
Fix formatting in another place
stevenfontanella Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
runs-on: ubuntu-latest
env:
# Keep this in sync with clang-format-diff.sh
LLVM_VERSION: 17
LLVM_VERSION: 21
steps:
- uses: actions/setup-python@v5
with:
Expand Down
2 changes: 1 addition & 1 deletion scripts/clang-format-diff.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ else
BRANCH="@{upstream}"
fi

LLVM_VERSION=${LLVM_VERSION:=17}
LLVM_VERSION=${LLVM_VERSION:=21}

MERGE_BASE=$(git merge-base $BRANCH HEAD)
FORMAT_ARGS="--binary=clang-format-${LLVM_VERSION} ${MERGE_BASE}"
Expand Down
2 changes: 1 addition & 1 deletion src/tools/wasm-ctor-eval.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ class EvallingModuleRunner;

class EvallingImportResolver : public ImportResolver {
public:
EvallingImportResolver() : stubLiteral({Literal(0)}){};
EvallingImportResolver() : stubLiteral({Literal(0)}) {};

// Return an unused stub value. We throw FailToEvalException on reading any
// imported globals. We ignore the type and return an i32 literal since some
Expand Down
2 changes: 1 addition & 1 deletion src/wasm/wasm-ir-builder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1075,7 +1075,7 @@ Result<> IRBuilder::visitEnd() {
tryy->name = scope.label;
tryy->finalize(tryy->type);
push(maybeWrapForLabel(tryy));
} else if (Try * tryy;
} else if (Try* tryy;
(tryy = scope.getCatch()) || (tryy = scope.getCatchAll())) {
auto index = scope.getIndex();
setCatchBody(tryy, *expr, index);
Expand Down
Loading