Skip to content

Remove wit-abi stuff we are not using #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Remove wit-abi stuff we are not using #23

wants to merge 2 commits into from

Conversation

yamt
Copy link
Contributor

@yamt yamt commented Jan 5, 2023

It's just confusing to have unmaintained files. Let's remove them.
When/if we change our mind, it's trivial to revive them.

yamt added 2 commits January 5, 2023 19:52
@yamt
Remove broken CI workflow
3278fd3
@yamt
Remove wit-abi stuff we are not using
ccd7887 
It's just confusing to have unmaintained files. Let's remove them.
When/if we change our mind, it's trivial to revive them.
abrown
abrown requested changes Jan 5, 2023
View reviewed changes
Copy link
Collaborator

@abrown abrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to just fix the CI errors instead since having a WIT specification is the most formal part of this proposal.

@yamt yamt mentioned this pull request Jan 6, 2023
Merged
@yamt
Copy link
Contributor Author

yamt commented Jan 6, 2023

I would prefer to just fix the CI errors instead since having a WIT specification is the most formal part of this proposal.

#24

@loganek
Copy link
Collaborator

loganek commented Jan 20, 2023

@yamt can we close this PR? The CI is green now thanks to your change (#24) and we'll continue updates here: #26

@yamt
Copy link
Contributor Author

yamt commented Jan 20, 2023 •
edited
Loading

@yamt can we close this PR? The CI is green now thanks to your change (#24) and we'll continue updates here: #26

i will close this once #26 is merged. (it's taking longer than i expected)

@loganek
Copy link
Collaborator

loganek commented Jan 20, 2023

#26 is merged, I'm closing this PR

@loganek loganek closed this Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abrown abrown abrown requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yamt @loganek @abrown