-
Notifications
You must be signed in to change notification settings - Fork 34
Desafio 1 #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Desafio 1 #11
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lu, como nessa primeira fase estamos focando apenas no HTML recomendo remover os arquivos CSS inline e incluí-los dentro de um arquivo .css e depois importá-lo usando o <link rel="stylesheet" href="style.css"> no seu index.html dentro da tag <head>.
portfolio_lu.html
Outdated
| <a href="#contato" style="color:whitesmoke">Contato</a> | ||
| </header> | ||
| <section style="background-color:deeppink; background-image:url(https://github.com/lucominato/front-end-study-group-rj/blob/master/images/Slider.png?raw=true)"> | ||
| <h1 id="home">Bem vind@</h1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dica: em vez de usar id's, use classes. Id é recomendável usar para 1x para referenciar algum bloco de elemento, por exemplo. Classes você pode repetí-las em diversos momentos.
ID - Uma única por página. Identificador: #
CLASS - Múltiplas por elemento/página. Identificador: .
| <h1 id="home">Bem vind@</h1> | |
| <h1>Bem vind@</h1> |
Caso a intenção tenha sido incluir um id para cada um desses h1 indicando a sua sessão (home, serviços, etc) recomendo inserir uma classe dentro das <section>.
Exemplo: <section class="home">.
portfolio_lu.html
Outdated
| <h3 style="color:orangered; text-align:center">Dois mollius placerat quellen ergo est bloo dignissum felinum</h3> | ||
| <img src="https://github.com/lucominato/front-end-study-group-rj/blob/master/images/photo.png?raw=true" width="290" height="290"> | ||
| <h4 style="color:orangered; text-align:center">Joana d'Arc</h4> | ||
| <p><h2 style="color:orangered; text-align:center">Sobre mim</h2></p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <p><h2 style="color:orangered; text-align:center">Sobre mim</h2></p> | |
| <h4>Sobre mim</h4> |
Evite usar parágrafo <p> dentro de qualquer tag de hipertexto (no caso você usou pra englobar o <h2>).
Ou você usa o <p> ou o <h2>.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
portfolio_lu.html
Outdated
| <a href="#quem_sou_eu" style="color:whitesmoke">Quem Sou Eu</a> | ||
| <a href="#contato" style="color:whitesmoke">Contato</a> | ||
| </header> | ||
| <section style="background-color:deeppink; background-image:url(https://github.com/lucominato/front-end-study-group-rj/blob/master/images/Slider.png?raw=true)"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <section style="background-color:deeppink; background-image:url(https://github.com/lucominato/front-end-study-group-rj/blob/master/images/Slider.png?raw=true)"> | |
| <section class="home"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dica: em vez de usar id's, use classes. Id é recomendável usar para 1x para referenciar algum bloco de elemento, por exemplo. Classes você pode repetí-las em diversos momentos.
| <td><img src="https://github.com/lucominato/front-end-study-group-rj/blob/master/images/Service3.png?raw=true" width="290" height="290"></td> | ||
| </tr> | ||
| <tr> | ||
| <td><h3 style="color:orangered; text-align:center">Websites</h3></td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <td><h3 style="color:orangered; text-align:center">Websites</h3></td> | |
| <td>Websites</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Você não precisa incluir uma tag de texto dentro de uma tag de tabela. A sugestão aqui é que você pode customizar o tamanho da fonte, cor e peso dela no CSS.
portfolio_lu.html
Outdated
| </section> | ||
| <section style="background-color:gold"> | ||
| <h1 id="contato" style="color:deeppink; text-align:center">Contato</h1> | ||
| <h3 style="color:black; text-align:center">Dois mollius placerat quellen ergo est sancto</h3> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <h3 style="color:black; text-align:center">Dois mollius placerat quellen ergo est sancto</h3> | |
| <p>Dois mollius placerat quellen ergo est sancto</p> |
Essa parte de Contatos você pode usar apenas a tag <p> mesmo de parágrafo em vez de algum que represente título ou subtítulo. É um texto corrido.
portfolio_lu.html
Outdated
| <section style="background-color:gold"> | ||
| <h1 id="contato" style="color:deeppink; text-align:center">Contato</h1> | ||
| <h3 style="color:black; text-align:center">Dois mollius placerat quellen ergo est sancto</h3> | ||
| <h3 style="color:black; text-align:center">[email protected]</h3> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <h3 style="color:black; text-align:center">[email protected]</h3> | |
| <p>[email protected]</p> |
portfolio_lu.html
Outdated
| <h1 id="contato" style="color:deeppink; text-align:center">Contato</h1> | ||
| <h3 style="color:black; text-align:center">Dois mollius placerat quellen ergo est sancto</h3> | ||
| <h3 style="color:black; text-align:center">[email protected]</h3> | ||
| <h3 style="color:whitesmoke; text-align:center">+55 21 23456-7890</h3> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <h3 style="color:whitesmoke; text-align:center">+55 21 23456-7890</h3> | |
| <p>+55 21 23456-7890</p> |
portfolio_lu.html
Outdated
| <p><h2 style="color:orangered; text-align:center">Sobre mim</h2></p> | ||
| <h4 style="color:orangered; text-align:center">Lorem ipsum dolor sit amet, consectetur adipiscing elit. His similes sunt omnes, qui virtuti student levantur vitiis, levantur erroribus, nisi forte censes Ti. Re mihi non aeque satisfacit, et quidem locis pluribus. Quippe: habes enim a rhetoribus; Duo Reges: constructio interrete.</h4> | ||
| <h3 style="color:orangered">Habilidades</h3> | ||
| <h4 style="color:whitesmoke">JavaScript</h4> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <h4 style="color:whitesmoke">JavaScript</h4> | |
| <ul> | |
| <li>Javascript</li> | |
| <li>HTML e CSS</li> | |
| <li>CSS</li> | |
| <li>WordPress</li> | |
| </ul> |
Em vez de usar o h3 para fazer uma lista use as tags <ul>e <li>para criar listas :)
|
Boa, @lucominato! Lembrando que os desafios 2 e 3 já estão disponíveis, tá? |
@bezoccoaline @cmoutella @camilahgp