Desafio 1 #11
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,81 @@ | ||||||||||||||||
| <!doctype html> | ||||||||||||||||
| <html> | ||||||||||||||||
| <head> | ||||||||||||||||
| <meta charset="utf-8"> | ||||||||||||||||
| <title>Luciana Cominato</title> | ||||||||||||||||
| </head> | ||||||||||||||||
| <body> | ||||||||||||||||
| <header style="background-color:black"> | ||||||||||||||||
| <img src="https://github.com/lucominato/front-end-study-group-rj/blob/master/images/logo.png?raw=true" width="100" height="30"> | ||||||||||||||||
| <a href="#home" style="color:whitesmoke">Home</a> | ||||||||||||||||
| <a href="#serviços" style="color:whitesmoke">Serviços</a> | ||||||||||||||||
| <a href="#meus_trabalhos" style="color:whitesmoke">Meus Trabalhos</a> | ||||||||||||||||
| <a href="#quem_sou_eu" style="color:whitesmoke">Quem Sou Eu</a> | ||||||||||||||||
| <a href="#contato" style="color:whitesmoke">Contato</a> | ||||||||||||||||
| </header> | ||||||||||||||||
| <section style="background-color:deeppink; background-image:url(https://github.com/lucominato/front-end-study-group-rj/blob/master/images/Slider.png?raw=true)"> | ||||||||||||||||
| <h1 id="home">Bem vind@</h1> | ||||||||||||||||
|
||||||||||||||||
| <h1 id="home">Bem vind@</h1> | |
| <h1>Bem vind@</h1> |
Caso a intenção tenha sido incluir um id para cada um desses h1 indicando a sua sessão (home, serviços, etc) recomendo inserir uma classe dentro das <section>.
Exemplo: <section class="home">.
Contributor
There was a problem hiding this comment.
Suggested change
| <td><h3 style="color:orangered; text-align:center">Websites</h3></td> | |
| <td>Websites</td> |
Contributor
There was a problem hiding this comment.
Você não precisa incluir uma tag de texto dentro de uma tag de tabela. A sugestão aqui é que você pode customizar o tamanho da fonte, cor e peso dela no CSS.
Outdated
Contributor
There was a problem hiding this comment.
Suggested change
| <p><h2 style="color:orangered; text-align:center">Sobre mim</h2></p> | |
| <h4>Sobre mim</h4> |
Evite usar parágrafo <p> dentro de qualquer tag de hipertexto (no caso você usou pra englobar o <h2>).
Ou você usa o <p> ou o <h2>.
Outdated
Contributor
There was a problem hiding this comment.
Suggested change
| <h4 style="color:whitesmoke">JavaScript</h4> | |
| <ul> | |
| <li>Javascript</li> | |
| <li>HTML e CSS</li> | |
| <li>CSS</li> | |
| <li>WordPress</li> | |
| </ul> |
Em vez de usar o h3 para fazer uma lista use as tags <ul>e <li>para criar listas :)
Outdated
Contributor
There was a problem hiding this comment.
Suggested change
| <h3 style="color:black; text-align:center">Dois mollius placerat quellen ergo est sancto</h3> | |
| <p>Dois mollius placerat quellen ergo est sancto</p> |
Essa parte de Contatos você pode usar apenas a tag <p> mesmo de parágrafo em vez de algum que represente título ou subtítulo. É um texto corrido.
Outdated
Contributor
There was a problem hiding this comment.
Suggested change
| <h3 style="color:black; text-align:center">[email protected]</h3> | |
| <p>[email protected]</p> |
Outdated
Contributor
There was a problem hiding this comment.
Suggested change
| <h3 style="color:whitesmoke; text-align:center">+55 21 23456-7890</h3> | |
| <p>+55 21 23456-7890</p> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dica: em vez de usar id's, use classes. Id é recomendável usar para 1x para referenciar algum bloco de elemento, por exemplo. Classes você pode repetí-las em diversos momentos.