-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Packages: Add support for publishing stable release of pre-release package #74332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Size Change: 0 B Total Size: 3.08 MB ℹ️ View Unchanged
|
tyxla
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, thanks for following up 👍 🚀
| 'Fifth line', | ||
| ], | ||
| 'patch', | ||
| '0.1.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably overkill, but do we also need a test that "Stable release" promotes to major only if it's currently on < 1.0.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably overkill, but do we also need a test that "Stable release" promotes to major only if it's currently on < 1.0.0?
I think it could make sense. In earlier iterations I had been more explicit in documentation that "Stable release" heading would have no effect on stable packages, which would imply it's an expected behavior we should test for.
Updated in fa3bfaf
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Co-authored-by: Marin Atanasov <[email protected]>
This reverts commit 96dbb11.
b72050f to
6a263dc
Compare
|
Flaky tests detected in 6a263dc. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/20751624503
|
…ckage (#74332) * Packages: Add support for publishing stable release of pre-release package * Add code syntax highlighting for version specifiers Co-authored-by: Marin Atanasov <[email protected]> * Add test case for no effect on stable versions * TypeScript-ify common bin script * Revert "TypeScript-ify common bin script" This reverts commit 96dbb11. --------- Co-authored-by: Marin Atanasov <[email protected]> Co-authored-by: aduth <[email protected]> Co-authored-by: tyxla <[email protected]>
What?
Follow-up to #74285
Updates the packages publishing workflow script to detect a "stable release" heading in a package changelog to allow a pre-release 0.x package to be bumped to 1.0.0.
Why?
Without these changes, a
<1.0.0package can never become a>=1.0.0package.Testing Instructions
Review included documentation changes for accuracy.
Verify tests pass: